Unify SDK boolean query encoding and HTTP error classification - #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tasks.list(completed=True) sent completed=True through urllib, but the API recognizes the lowercase literal true. Both transports now share boolean normalization, and the old test that pinned the wrong casing is corrected.
Share HTTP error classification in the existing transport module as well. Non-object JSON error bodies now retain the appropriate SDK exception class instead of producing AttributeError, and nested error messages behave consistently between urllib and httpx. Public methods and exception classes remain unchanged.
Validation: all 147 tests passed. New transport-contract checks exercise actual urllib/httpx request construction and five error statuses against object, nested, null, array, and text bodies. Against the original implementation, 17 of those cases fail as expected. No new runtime dependency.
Merging runs CI. PyPI publication requires a separate version/tag release.