Cleanup automation for cleanup with and without volume flag and csi volume exporter - #5139
Merged
priti-parate merged 49 commits intoSep 4, 2026
Conversation
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
…, Added offline image warning with specific image list, Integrated powerscale_telemetry_validation into telemetry_validation, Removed proxyHost validation Signed-off-by: priti_parate <priti_parate@dell.com>
…nia-modernization
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
…nia-modernization
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
…odernization Signed-off-by: priti-parate <140157516+priti-parate@users.noreply.github.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
…riti-parate/omnia into issue-4849-omnia-modernization
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
…odernization Signed-off-by: priti-parate <140157516+priti-parate@users.noreply.github.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
Resolved conflict in cleanup_func.py by using updated variable names from remote (LDMS_AGG_STS_NAME, LDMS_STORE_NAME, etc.) and removing DCGM_POD_PREFIX as part of DCGM removal.
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
… work Resolved conflicts: - install_python_dependencies.yml: kept the generic component-driven design and made 'component' optional (defaults to new 'base' package set) so the telemetry_setup caller, which passes no component, still installs the K8s client as it did before. - telemetry_packages.yml: added 'base' pip_modules component for the above. - deploy_powerscale/vars/main.yml: kept the static ps_clusters_found_msg; the incoming version counted user_helm_values.isilon, a key that does not exist in the CSM observability values file. - telemetry_msgs.py: kept both the offline-mode and LDMS message entries. - test_creds.yml: accepted upstream deletion; it is gitignored as auto-generated credentials and stays untracked locally. - test/telemetry/README.md: reconciled the FVT test-count table. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
install_python_dependencies.yml is restored verbatim to the component-driven implementation: 'component' stays required, packages come from the pip_modules.<component> map in telemetry_packages.yml, and each package is installed via install_single_python_package.yml. Reverted the merge-time accommodations made for the incoming version: dropped the 'base' pip_modules component, and dropped the componentless install_python_dependencies call that the incoming change added to telemetry_setup, since it would trip the 'component is provided' assert. Components install their own dependencies at enable time (see deploy_idrac_telemetry).
…_sync.yml - Uncommented precheck flow in telemetry.yml with tags [never, precheck] to match other opt-in flows - Removed src/telemetry/test_bmc_sync.yml
Signed-off-by: priti_parate <priti_parate@dell.com>
- Fixed yaml[empty-lines] errors in generate_root_kustomization.yml and helm_install_karavi.yml - Replaced ignore_errors with failed_when in verify_idrac_telemetry.yml and enable.yml - Added FQCN prefix to include_tasks in install_python_dependencies.yml - Fixed yaml[line-length] in generate_root_kustomization.yml and precheck.yml - Fixed yaml[trailing-spaces] in check_powerscale_privileges.yml - Added newline at end of helm_install_karavi.yml Signed-off-by: priti_parate <priti_parate@dell.com>
- Fixed line-too-long errors in telemetry_msgs.py by splitting long strings - Removed duplicate 'deployment_failed' key in TEST_LOG_MSGS - Added trailing newlines to telemetry_msgs.py and test_case_vars.py Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
- Removed extra trailing newlines from telemetry_msgs.py and test_case_vars.py Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
…riti-parate/omnia into issue-4849-omnia-modernization
…riti-parate/omnia into issue-4849-omnia-modernization
Signed-off-by: Super User <root@priti.omnia.dev>
Signed-off-by: Super User <root@priti.omnia.dev>
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
…odernization Signed-off-by: priti-parate <140157516+priti-parate@users.noreply.github.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
priti-parate
marked this pull request as ready for review
September 3, 2026 12:29
abhishek-sa1
approved these changes
Sep 3, 2026
Collaborator
|
@priti-parate pr description to be updated |
balajikumaran-c-s
approved these changes
Sep 3, 2026
priti-parate
merged commit Sep 4, 2026
0e3da94
into
dell:issue-4849-omnia-modernization
11 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This PR implements cleanup automation with optional volume deletion, adds CSI volume exporter deployment for PowerScale telemetry, fixes SQL injection vulnerabilities in MySQL query handling, and resolves numerous Ansible lint and Pylint issues across the telemetry domain.
Changes
Cleanup Automation
Added
Delete_volumeflag to control volume cleanup during telemetry cleanup operationsUpdated cleanup functions in
cleanup_func.pyto support both volume-preserving and volume-deleting cleanup modesAdded new test cases for cleanup automation with and without volume deletion
Updated test messages and variables to reflect new cleanup behavior
CSI Volume Exporter
Deployed CSI volume exporter for PowerScale telemetry metrics collection
Simplified CSI volume exporter template for better maintainability
Integrated CSI volume exporter with PowerScale telemetry deployment playbooks
Added test cases for CSI volume exporter functionality
SQL Injection Fixes
Refactored MySQL query handling in iDRAC IP retrieval modules
Fixed SQL injection vulnerabilities in
insert_idracips_mysqldb.pyandread_idracips_from_mysqldb.pyUpdated
delete_idracips_from_mysqldb.pyfor secure query handlingReplaced raw SQL concatenation with parameterized queries
PowerScale Telemetry
Removed DCGM from telemetry domain
Updated PowerScale validation to remove image version cross-validation
Added offline image warning with specific image list
Integrated powerscale_telemetry_validation into telemetry_validation
Removed proxyHost validation
Updated cluster mount variables from
cluster_mounttok8s_cluster_mountAdded Slurm cluster mount support for LDMS
Code Quality Improvements
Fixed Ansible lint errors across telemetry roles:
Fixed
yaml[empty-lines]errors in generate_root_kustomization.yml and helm_install_karavi.ymlReplaced
ignore_errorswithfailed_when: falsein verify_idrac_telemetry.yml and enable.ymlAdded FQCN prefix to include_tasks in install_python_dependencies.yml
Fixed
yaml[line-length]in generate_root_kustomization.yml and precheck.ymlFixed
yaml[trailing-spaces]in check_powerscale_privileges.ymlAdded newline at end of helm_install_karavi.yml
Fixed Pylint errors in test telemetry library files:
Fixed line-too-long errors in telemetry_msgs.py by splitting long strings
Removed duplicate 'deployment_failed' key in TEST_LOG_MSGS
Added trailing newlines to telemetry_msgs.py and test_case_vars.py
Infrastructure Changes
Updated orchestrator inventory with kube_vip support
Uncommented precheck play in telemetry.yml with tags [never, precheck]
Removed obsolete test_bmc_sync.yml
Updated input file loading to use OMNIA_DATA_PATH environment variable
Removed unused CSI secret path variable
Removed unused functions and updated required functions
Files Changed
Testing
Verified cleanup automation with and without volume deletion
Tested CSI volume exporter deployment and functionality
Validated SQL injection fixes through security testing
Ran Ansible lint suite - all errors resolved
Ran Pylint on test library files - all errors resolved
Tested PowerScale telemetry deployment with new validation logic
Verified offline mode image comparison with telemetry_packages.yml
Backward Compatibility
Cleanup automation is backward compatible - volume deletion is opt-in via Delete_volume flag
SQL injection fixes maintain existing functionality while improving security
CSI volume exporter is a new feature with no impact on existing deployments
Variable name changes (cluster_mount → k8s_cluster_mount) are internal and don't affect user input
DCGM removal is a breaking change for DCGM-dependent deployments (deprecated component)
Suggested Reviewers
@Abhishek-Sa1 @balajikumaran-c-s