fix(orchestrator): add kube_vip group in inventory only when K8s functional groups are defined - #5151
Merged
abhishek-sa1 merged 2 commits intoSep 4, 2026
Conversation
Signed-off-by: priti_parate <priti_parate@dell.com>
Signed-off-by: priti_parate <priti_parate@dell.com>
priti-parate
marked this pull request as ready for review
September 4, 2026 10:46
abhishek-sa1
approved these changes
Sep 4, 2026
balajikumaran-c-s
approved these changes
Sep 4, 2026
abhishek-sa1
merged commit Sep 4, 2026
131ef73
into
dell:issue-4849-omnia-modernization
14 checks passed
Kratika-P
pushed a commit
to Kratika-P/omnia
that referenced
this pull request
Sep 7, 2026
…tional groups are defined (dell#5151) * Add kube vip group in inventory only when kubernetes cluster is defined Signed-off-by: priti_parate <priti_parate@dell.com> * simplify condition to add kube vip in inventory Signed-off-by: priti_parate <priti_parate@dell.com> --------- Signed-off-by: priti_parate <priti_parate@dell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Solution
Summary: Fixes kube_vip group being incorrectly added to orchestrator inventory when Kubernetes is not actually deployed. The kube_vip group is now only added when K8s functional groups (service_kube_*) are defined in the PXE mapping file, which is the definitive indicator that K8s should be deployed.
Changes
generate_inventories role
orchestrator_inventory template
Files Changed
src/orchestrator/roles/generate_inventories/tasks/main.ymlsrc/orchestrator/roles/configure_ochami/templates/nodes/orchestrator_inventory.yaml.j2Testing
Backward Compatibility