Fix local items file permissions - #170
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix local Docker reads from saved item lists when the source CSV is not readable by the non-root engine user.
SPT downloads result artifacts with mode
0600. When the CLI is run as root, a saveditems.csvis therefore root-owned and cannot be read by the container image userspt. The local launcher previously bind-mounted that source file directly, causing the engine to report that it could not open/spt-input/items/read-items.csv.Local Docker runs now stage an exact temporary copy, explicitly set the copy to read-only mode
0444, and bind-mount that copy. The original file and its permissions remain unchanged. Staged files are removed during both normal cleanup and manager close. Remote execution is unchanged because it already stages item files and applies0444.