Skip to content

Invert BaseBufferExceedsShareReserves revert condition #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2023
Merged

Invert BaseBufferExceedsShareReserves revert condition #50

merged 1 commit into from
Feb 8, 2023

Conversation

@Padraic-O-Mhuiris
Copy link
Contributor

@Padraic-O-Mhuiris Padraic-O-Mhuiris commented Feb 8, 2023

No description provided.

@Padraic-O-Mhuiris Padraic-O-Mhuiris merged commit 1c5fd4f into main Feb 8, 2023
@Padraic-O-Mhuiris Padraic-O-Mhuiris deleted the base-buffer-exceeds-share-reserves-revert-fix branch February 8, 2023 15:09
jalextowle added a commit that referenced this pull request Feb 27, 2024
@jalextowle
Spearbit #50: Fixed the round trip property with fees in closeLong. (…
46c834d 
…#767)

* Fixed the round trip property with fees in `closeLong`

* Adds a round trip test for shorts
jalextowle added a commit that referenced this pull request Feb 29, 2024
@jalextowle
Spearbit #50: Fixed the round trip property with fees in closeLong. (…
5291eb1 
…#767)

* Fixed the round trip property with fees in `closeLong`

* Adds a round trip test for shorts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleph-v aleph-v Awaiting requested review from aleph-v

1 more reviewer

@jalextowle jalextowle jalextowle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Padraic-O-Mhuiris @jalextowle