Skip to content

Invert BaseBufferExceedsShareReserves revert condition #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Invert BaseBufferExceedsShareReserves revert condition #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/Hyperdrive.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ contract Hyperdrive is MultiToken {
// Since the base buffer may have increased relative to the base
// reserves and the bond reserves decreased, we must ensure that the
// base reserves are greater than the longsOutstanding.
if (sharePrice.mulDown(shareReserves) >= longsOutstanding) {
if (sharePrice.mulDown(shareReserves) < longsOutstanding) {
revert Errors.BaseBufferExceedsShareReserves();
}

Expand Down Expand Up @@ -381,7 +381,7 @@ contract Hyperdrive is MultiToken {

// Since the share reserves are reduced, we need to verify that the base
// reserves are greater than or equal to the amount of longs outstanding.
if (sharePrice.mulDown(shareReserves) >= longsOutstanding) {
if (sharePrice.mulDown(shareReserves) < longsOutstanding) {
revert Errors.BaseBufferExceedsShareReserves();
}

Expand Down