bug: Use latest checkpoint vaultSharePrice if it exists when minting past checkpoints
#809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryangoree
changed the title
vaultSharePrice if it exists when minting past checkpoints
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
ryangoree
force-pushed
the
ryan/fix/closest-checkpoint-price
branch
from
c0bddc8 to
11cf464
Compare
jalextowle
reviewed
Mar 1, 2024
jalextowle
approved these changes
Mar 1, 2024
Contributor
jalextowle
left a comment
jalextowle
left a comment
There was a problem hiding this comment.
Looks great! Just one nit, and then it looks good to go. Nice job!
ryangoree
force-pushed
the
ryan/fix/closest-checkpoint-price
branch
from
c54f014 to
4a17000
Compare
jalextowle
added a commit
that referenced
this pull request
Mar 2, 2024
…g past checkpoints (#809) * Prevent fetching the latest share price if a closer share price has already been fetched * Update unit test * Update test/units/hyperdrive/CheckpointTest.t.sol Co-authored-by: Alex Towle <jalextowle@gmail.com> --------- Co-authored-by: Alex Towle <jalextowle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #808
I removed some logic in the
test_checkpoint_in_the_pasttest that was already tested in thetest_checkpoint_redemption, but lmk if this goes against your testing philosophy.