Skip to content

bug: Use latest checkpoint vaultSharePrice if it exists when minting past checkpoints #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2024
Merged

bug: Use latest checkpoint vaultSharePrice if it exists when minting past checkpoints #809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9270e7c
Prevent fetching the latest share price if a closer share price has a…
ryangoree Feb 29, 2024
4a17000
Update unit test
ryangoree Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/src/internal/HyperdriveCheckpoint.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ abstract contract HyperdriveCheckpoint is
) {
uint256 closestVaultSharePrice = _checkpoints[time]
.vaultSharePrice;
if (time == latestCheckpoint) {
if (time == latestCheckpoint && closestVaultSharePrice == 0) {
closestVaultSharePrice = _pricePerVaultShare();
}
if (closestVaultSharePrice != 0) {
Expand Down
44 changes: 13 additions & 31 deletions test/units/hyperdrive/CheckpointTest.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,44 +116,26 @@ contract CheckpointTest is HyperdriveTest {
// Initialize the Hyperdrive pool.
initialize(alice, 0.05e18, 500_000_000e18);

// Open a long and a short.
openLong(bob, 10_000_000e18);
uint256 shortAmount = 50_000e18;
openShort(celine, shortAmount);

// Advance a term.
vm.warp(block.timestamp + POSITION_DURATION);

// Create a checkpoint.
hyperdrive.checkpoint(HyperdriveUtils.latestCheckpoint(hyperdrive));

// Update the share price.
MockHyperdrive(address(hyperdrive)).accrue(CHECKPOINT_DURATION, .1e18);

// Create a checkpoint in the past.
uint256 previousCheckpoint = HyperdriveUtils.latestCheckpoint(
hyperdrive
) - hyperdrive.getPoolConfig().checkpointDuration;
hyperdrive.checkpoint(previousCheckpoint);

// TODO: This should be either removed or uncommented when we decide
// whether or not the flat+curve invariant should have an impact on
// the market rate.
//
// Ensure that the pool's APR wasn't changed by the checkpoint.
// assertEq(calculateSpotAPR(hyperdrive), aprBefore);

// Ensure that the checkpoint contains the share price prior to the
// share price update.
IHyperdrive.Checkpoint memory checkpoint = hyperdrive.getCheckpoint(
HyperdriveUtils.latestCheckpoint(hyperdrive)
);
IHyperdrive.PoolInfo memory poolInfo = hyperdrive.getPoolInfo();
assertEq(checkpoint.vaultSharePrice, poolInfo.vaultSharePrice);

// Ensure that the previous checkpoint contains the closest share price.
checkpoint = hyperdrive.getCheckpoint(previousCheckpoint);
assertEq(checkpoint.vaultSharePrice, poolInfo.vaultSharePrice);

// Ensure that the long and short balance has gone to zero (all of the
// matured positions have been closed).
assertEq(poolInfo.longsOutstanding, 0);
assertEq(poolInfo.shortsOutstanding, 0);
// Ensure the previous checkpoint contains the share price prior to the
// update since a more recent checkpoint was already created.
uint256 latestCheckpointSharePrice = hyperdrive
.getCheckpoint(HyperdriveUtils.latestCheckpoint(hyperdrive))
.vaultSharePrice;
uint256 previousCheckpointSharePrice = hyperdrive
.getCheckpoint(previousCheckpoint)
.vaultSharePrice;
assertEq(latestCheckpointSharePrice, previousCheckpointSharePrice);
}
}