Adopt DemaConsulting.Rendering packages and update compliance docs - #12
Merged
Conversation
Replace SysML2Tools' internal copy of the SysML-agnostic layout/rendering code with the released DemaConsulting.Rendering 0.1.0-beta.2 packages. Core now references DemaConsulting.Rendering.Layout (transitively Rendering + Abstractions); the Tool references the Svg and Skia renderer packages. The internal Svg and Png projects and the layout-engine, IR, and rendering-contract sources are removed. The four engine-using view strategies (General, Interconnection, ActionFlow, StateTransition) are rewritten from the internal engine APIs to the public facades via a new LayeredPlacement helper that wraps LayeredLayoutAlgorithm, plus ContainmentLayout and ConnectorRouter. beta.2 honors Direction=Down, so the vertical-flow views migrate faithfully. Stale engine and library-type unit tests are removed; the remaining strategy and rendering tests are re-pointed to the package namespaces. Builds green and all tests pass on net8.0/net9.0/net10.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the requirements, design, and verification artifacts for the layout IR, layout engines, shared metrics, rendering contracts, theme, and the Svg/Png systems that were deleted from the codebase and now come from the DemaConsulting.Rendering packages. Add the packages as a DemaConsulting.Rendering OTS item (requirements + verification, each linked to real passing SysML2Tools tests) and document the new LayeredPlacement adapter unit. Rewire requirements.yaml, .reviewmark.yaml, the design/verification introductions, and the document assembly definitions. lint.ps1 passes (reqstream, reviewmark, versionmark, yamllint, cspell, markdownlint, dotnet format). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Regenerate the committed gallery renders from the sample models with the migrated layout. Six of the eight views are byte-identical; the General (drone) and State Transition (elevator) views shift slightly because the layered and containment algorithms in the DemaConsulting.Rendering packages pack and space nodes marginally differently from the previous internal engine. Only those two views' SVG and PNG outputs change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix migration-caused documentation staleness surfaced by the formal-review pass over the affected review-sets: - action-flow / state-transition strategy design: drop stale NotationMetrics and Theme.CleanLegMargin back-edge wording; note the ~1px cosmetic back-edge difference from the dropped BackEdgeEntryApproach knob. - general strategy design: cite the ContainmentLayout.Pack / ConnectorRouter.Route / BoxMetrics OTS calls; labelled -> labeled. - diagram-renderer design: drop 'future phase injects ILayoutStrategy' wording; mark LayoutTree / IRenderer / RenderOptions / RenderOutput as OTS-owned. - rendering.yaml: retarget the mis-traced ILayoutStrategy requirement onto real end-to-end BuildLayout tests (SoftwareStructureModel/GeneralViewModel render). - ots/dema-rendering.yaml: narrow the routing requirement wording to the tested evidence. - LayeredPlacement.cs: add <exception> XML doc to Place. Build green; lint.ps1 green. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Close the Contracts formal-review finding that rendering.yaml framed contracts now owned by DemaConsulting.Rendering.Abstractions/Svg/Skia as subsystem-provided. Reword the IRenderer, Theme, RenderOptions, and BuiltinThemes requirement titles to consumption phrasing (render/style/configure using off-the-shelf ...). IDs and traced tests are unchanged, so traceability is preserved; all referenced tests still exist in RenderingTests.cs and pass. lint.ps1 green. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant architectural and documentation changes to reflect the migration from in-house layout and rendering engines to off-the-shelf packages (
DemaConsulting.Rendering). The SysML2Tools codebase and its documentation are updated to remove references to the custom SVG/PNG renderers and geometric layout engines, and instead document the integration and usage of the off-the-shelf rendering and layout solutions. This streamlines the design, clarifies the new dependencies, and simplifies the project structure.Key changes include:
1. Removal of custom SVG/PNG renderer projects and documentation
DemaConsulting.SysML2Tools.SvgandDemaConsulting.SysML2Tools.Pngprojects and their associated test projects from the solution file (DemaConsulting.SysML2Tools.slnx).2. Migration to off-the-shelf rendering and layout packages
DemaConsulting.RenderingandDemaConsulting.Rendering.Layoutpackages, including the introduction of theLayeredPlacementadapter. [1] [2] [3] [4] [5] [6] [7]3. Documentation and design file updates
4. Project and solution structure simplification
5. Clarification of third-party dependencies
DemaConsulting.Rendering.Skiapackage, and documented the implications for consumers. [1] [2]These changes collectively modernize the codebase and documentation, making maintenance easier and aligning the project with current architectural decisions.