add new cloudflare ruleset commands

[andrew-paloalto]

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

• In Progress
• Ready
• In Hold - (Reason for hold)

Related Issues

[content-bot]

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

[content-bot]

Hi @andrew-paloalto, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

[content-bot]

🤖 AI-Powered Code Review Available

Hi @kamalq97, you can leverage AI-powered code review to assist with this PR!

Available Commands:

• @marketplace-ai-reviewer start review - Initiate a full AI code review
• @marketplace-ai-reviewer re-review - Incremental review for new commits

[marketplace-ai-reviewer]

🤖 Analysis started. Please wait for results...

[marketplace-ai-reviewer]

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

[marketplace-ai-reviewer]

Hi! Thanks for your contribution adding new ruleset commands to the Cloudflare WAF integration. I've left a few notes to help polish the PR, mostly focusing on standardizing descriptions and improving code robustness.

Please ensure you use .get() when accessing command arguments, add error handling for JSON parsing, and standardize the YAML descriptions (starting with "The" and ending with a period). Also, remember to update the README with the new commands and adjust the release notes version bump to reflect the new features rather than just a patch.

Thanks for your hard work!

Additionally, please address the following file-level notes:

• Packs/CloudflareWAF/Integrations/CloudflareWAF/README.md: The new ruleset management commands are missing from the README.md.
• Packs/CloudflareWAF/Integrations/CloudflareWAF/CloudflareWAF.yml: The first key defined at the root level of the .yml file must always be name or display. Currently, the file starts with sectionorder. Please reorder the keys so that name or display is at the top.

Additionally, please ensure that the README.md file is updated to include documentation for the newly added commands (cloudflare-waf-ruleset-list, cloudflare-waf-ruleset-get, cloudflare-waf-ruleset-create, cloudflare-waf-ruleset-update, cloudflare-waf-ruleset-delete).

• Packs/CloudflareWAF/pack_metadata.json: - The mandatory key created is missing from the pack metadata.
• The vendor name 'Cloudflare' is missing from the keywords array.
• Packs/CloudflareWAF/ReleaseNotes/1_0_38.md: The version bump type (patch) does not match the nature of the changes (new features).

@TheL0L please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

[TheL0L]

Thank you @andrew-paloalto for your contribution!

Aside from refactoring the two for-loops mentioned in the comments above, everything looks great.
Please address the remaining feedback from @marketplace-ai-reviewer so we can get this merged.

[TheL0L]

Hi @andrew-paloalto! Just a quick heads-up that this PR will be marked as stale and closed next week. If you still want to push this through, please tackle the remaining feedback from @marketplace-ai-reviewer. Let me know if you need any help!

[TheL0L]

Hi @andrew-paloalto, please address the failing unit test and execute the pre-commit hooks locally. Once the build passes, we can proceed with scheduling a demo.

[content-bot]

For the Reviewer: Trigger build request has been accepted for this contribution PR.

[content-bot]

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/10424594

[content-bot]

For the Reviewer: Trigger build request has been accepted for this contribution PR.

[content-bot]

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/10643509

[content-bot]

Validate summary
The following errors were thrown as a part of this pr: RM110, DO106.
The following errors can be ignored: RM110.
The following errors cannot be ignored: DO106.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: DO106.

Verdict: PR can be force merged from validate perspective? ❌

[github-actions]

Thank you for your contribution. Your external PR has been merged and the changes are now included in one or more internal PRs for further review.

Note

Contributions containing XSIAM content (Modeling Rules, Parsing Rules, Correlation Rules, or Dashboards) are subject to an additional review process and may take longer to be merged to master.