Skip to content

CRTX-258642 - OpenAI - XDM fix#44762

Merged
akshotiamit-pa merged 7 commits into
masterfrom
CRTX-258642-openai-mapping-fix
Jun 26, 2026
Merged

CRTX-258642 - OpenAI - XDM fix#44762
akshotiamit-pa merged 7 commits into
masterfrom
CRTX-258642-openai-mapping-fix

Conversation

@akshotiamit-pa

@akshotiamit-pa akshotiamit-pa commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Description

Must have

  • Tests
  • Documentation

@content-bot

content-bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@content-bot

This comment has been minimized.

Sign in to view
@akshotiamit-pa akshotiamit-pa added bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Jun 21, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Jun 21, 2026
@marketplace-ai-reviewer

marketplace-ai-reviewer commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer

marketplace-ai-reviewer commented Jun 21, 2026

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer
marketplace-ai-reviewer reviewed Jun 21, 2026
View reviewed changes

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution to the OpenAI pack. I've reviewed the PR and left a few notes to help polish it up. Mainly, the modeling rules need some minor tweaks to prevent data loss and unify observer types, and the pack metadata is missing the mandatory created key. There are also a few quick grammar and formatting adjustments needed in the release notes. Thanks again for your work on this!

Additionally, please address the following file-level notes:

  • Packs/OpenAI/pack_metadata.json: The mandatory key created is missing from pack_metadata.json.

@richardbluestone, @akshotiamit-pa please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/OpenAI/ModelingRules/OpenAIModelingRules/OpenAIModelingRules.xif
Comment thread Packs/OpenAI/ModelingRules/OpenAIModelingRules/OpenAIModelingRules.xif
Comment thread Packs/OpenAI/ModelingRules/OpenAIModelingRules/OpenAIModelingRules.xif Outdated
Comment thread Packs/OpenAI/ModelingRules/OpenAIModelingRules/OpenAIModelingRules.xif Outdated
Comment thread Packs/OpenAI/ReleaseNotes/2_1_1.md Outdated
Comment thread Packs/OpenAI/ReleaseNotes/2_1_1.md Outdated
Comment thread Packs/OpenAI/ReleaseNotes/2_1_1.md Outdated
@richardbluestone richardbluestone requested review from julieschwartz18 and removed request for richardbluestone June 21, 2026 10:04
julieschwartz18
julieschwartz18 reviewed Jun 21, 2026
View reviewed changes

@julieschwartz18 julieschwartz18 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshotiamit-pa Doc review complete. Please check the comments (also from marketplace-ai-reviewer - I agree with its comments as well :)
In the meantime, adding the label docs-approved

Comment thread Packs/OpenAI/ReleaseNotes/2_1_1.md Outdated
@akshotiamit-pa akshotiamit-pa requested a review from eepstain June 21, 2026 11:44
@content-bot

This comment has been minimized.

Sign in to view
@content-bot

This comment has been minimized.

Sign in to view
@content-bot

content-bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • OpenAI pack version was bumped to 2.1.2.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot

This comment has been minimized.

Sign in to view
@content-bot

This comment has been minimized.

Sign in to view
@content-bot

This comment has been minimized.

Sign in to view
@content-bot

This comment has been minimized.

Sign in to view
@akshotiamit-pa akshotiamit-pa force-pushed the CRTX-258642-openai-mapping-fix branch from ff3e0bc to b6bdb51 Compare June 25, 2026 17:57
@content-bot

content-bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

content-bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: success
Report ID: 3cd92bbb6698563d

📋 Triage Report

⚠️ AI-generated triage. Validate before acting.

@akshotiamit-pa akshotiamit-pa merged commit c197cef into master Jun 26, 2026
23 checks passed
@akshotiamit-pa akshotiamit-pa deleted the CRTX-258642-openai-mapping-fix branch June 26, 2026 06:33
eepstain pushed a commit that referenced this pull request Jun 28, 2026
@akshotiamit-pa @eepstain
CRTX-258642 - OpenAI - XDM fix (#44762)
49580ad 
* fix xdm mapping

* xql fix and docs review

* Map SaaS audit resource.id and resource.name per event type

* Bump pack from version OpenAI to 2.1.2.

* Map SaaS audit resource.id/name from per-type flat columns; extend audit schema

* Fix invalid identity_type enum: use IDENTITY_TYPE_APPLICATION for service accounts

* Fix resource.id guard: use 'in' with explicit null for non-resource event types

---------

Co-authored-by: Content Bot <bot@demisto.com>
socautomator pushed a commit to socautomator/content that referenced this pull request Jul 3, 2026
@akshotiamit-pa @socautomator
CRTX-258642 - OpenAI - XDM fix (demisto#44762)
0674f04 
* fix xdm mapping

* xql fix and docs review

* Map SaaS audit resource.id and resource.name per event type

* Bump pack from version OpenAI to 2.1.2.

* Map SaaS audit resource.id/name from per-type flat columns; extend audit schema

* Fix invalid identity_type enum: use IDENTITY_TYPE_APPLICATION for service accounts

* Fix resource.id guard: use 'in' with explicit null for non-resource event types

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julieschwartz18 julieschwartz18 julieschwartz18 left review comments
@marketplace-ai-reviewer marketplace-ai-reviewer marketplace-ai-reviewer left review comments
@eepstain eepstain eepstain approved these changes

Assignees

No one assigned

Labels

bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@akshotiamit-pa @content-bot @marketplace-ai-reviewer @julieschwartz18 @eepstain