[AUD Isolation] KeeperSecretsManager - from 2026-06-29#44907
Merged
shmuel44 merged 4 commits intoJul 14, 2026
Merged
Conversation
content-bot
requested review from
Moish-Gilboa,
Ni-Knight,
Shellyber and
shmuel44
June 29, 2026 22:19
Contributor
Author
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
This comment has been minimized.
This comment has been minimized.
Contributor
Author
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status:
|
shmuel44
approved these changes
Jul 14, 2026
shmuel44
deleted the
AUD-demisto/2026-06-29/gitlab-pipeline-10573496/878843-KeeperSecretsManager
branch
July 14, 2026 11:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke:
After bumping the docker image to
demisto/keeper-ksm:1.0.0.10221838, the teststest_get_file_commandand test_get_infofile_commandfailed with:TypeError: mock_download_get() got an unexpected keyword argument 'verify'Root cause:
The docker bump upgraded the keeper_secrets_manager_core library. The new version of its get_file_data() changed how it downloads file content. It now calls:
requests.get(file_url, verify=verify_ssl_certs, proxies=proxies)i.e. it passes verify and proxies keyword arguments. The older library version called requests.get(file_url) with a single positional argument only.
The tests mocked requests.get with a helper def mock_download_get(_): that accepts exactly one positional arg. When the upgraded library called it with keyword args, the mock signature couldn't absorb them → TypeError.
Why the integration is unaffected: Your integration code ksm_get_file just calls
f.get_file_data()on the library object. The extra verify/proxies kwargs are added internally by the library, not by your code. In production, realrequests.getaccepts those kwargs fine. Only the test's fakerequests.getwas too strict.[AUD Isolation] KeeperSecretsManager
This PR contains Docker image updates for a pack that failed tests in the main AUD PR.
GitLab Pipeline
Failure Details
Actual Changes
3 file(s) changed across 1 pack(s):
KeeperSecretsManager (3 files)
Packs/KeeperSecretsManager/Integrations/KeeperSecretsManager/KeeperSecretsManager.ymlPacks/KeeperSecretsManager/ReleaseNotes/1_0_29.mdPacks/KeeperSecretsManager/pack_metadata.json