Skip to content

[AUD Isolation] KeeperSecretsManager - from 2026-06-29#44907

Merged
shmuel44 merged 4 commits into
masterfrom
AUD-demisto/2026-06-29/gitlab-pipeline-10573496/878843-KeeperSecretsManager
Jul 14, 2026
Merged

[AUD Isolation] KeeperSecretsManager - from 2026-06-29#44907
shmuel44 merged 4 commits into
masterfrom
AUD-demisto/2026-06-29/gitlab-pipeline-10573496/878843-KeeperSecretsManager

Conversation

@content-bot

@content-bot content-bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

What broke:

After bumping the docker image to demisto/keeper-ksm:1.0.0.10221838 , the tests test_get_file_command and test_get_infofile_command failed with:
TypeError: mock_download_get() got an unexpected keyword argument 'verify'

Root cause:

The docker bump upgraded the keeper_secrets_manager_core library. The new version of its get_file_data() changed how it downloads file content. It now calls:

requests.get(file_url, verify=verify_ssl_certs, proxies=proxies)

i.e. it passes verify and proxies keyword arguments. The older library version called requests.get(file_url) with a single positional argument only.

The tests mocked requests.get with a helper def mock_download_get(_): that accepts exactly one positional arg. When the upgraded library called it with keyword args, the mock signature couldn't absorb them → TypeError.

Why the integration is unaffected: Your integration code ksm_get_file just calls f.get_file_data() on the library object. The extra verify/proxies kwargs are added internally by the library, not by your code. In production, real requests.get accepts those kwargs fine. Only the test's fake requests.get was too strict.

[AUD Isolation] KeeperSecretsManager

This PR contains Docker image updates for a pack that failed tests in the main AUD PR.

GitLab Pipeline

Failure Details

Item Reason Error
KeeperSecretsManager pytest Pytest failure - see logs for details

⚠️ Action Required: Please investigate and fix the failing tests before merging.

Actual Changes

3 file(s) changed across 1 pack(s):

KeeperSecretsManager (3 files)
  • Packs/KeeperSecretsManager/Integrations/KeeperSecretsManager/KeeperSecretsManager.yml
  • Packs/KeeperSecretsManager/ReleaseNotes/1_0_29.md
  • Packs/KeeperSecretsManager/pack_metadata.json

@content-bot content-bot added docs-approved auto-update-docker ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines skip-ai-review AUD-isolation labels Jun 29, 2026
@content-bot

Copy link
Copy Markdown
Contributor Author

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@content-bot

This comment has been minimized.

@content-bot

Copy link
Copy Markdown
Contributor Author

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: success
Report ID: 8ff42e0ccc357f76

📋 Triage Report

⚠️ AI-generated triage. Validate before acting.

@shmuel44
shmuel44 merged commit dc02c2f into master Jul 14, 2026
26 checks passed
@shmuel44
shmuel44 deleted the AUD-demisto/2026-06-29/gitlab-pipeline-10573496/878843-KeeperSecretsManager branch July 14, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AUD-isolation auto-update-docker docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines skip-ai-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants