Skip to content

refactor msft, googledrive to apimodule#44922

Merged
JudahSchwartz merged 15 commits into
masterfrom
standard_msft_gdrive
Jul 6, 2026
Merged

refactor msft, googledrive to apimodule#44922
JudahSchwartz merged 15 commits into
masterfrom
standard_msft_gdrive

Conversation

@JudahSchwartz

@JudahSchwartz JudahSchwartz commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/CRTX-260705

Description

Must have

  • Tests
  • Documentation

@content-bot

content-bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@JudahSchwartz JudahSchwartz added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 2, 2026
@content-bot

This comment has been minimized.

Sign in to view
@JudahSchwartz
JudahSchwartz force-pushed the standard_msft_gdrive branch from cc34b28 to c0c4e87 Compare July 2, 2026 11:02
@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ApiModules/Scripts/GoogleDriveApiModule
   GoogleDriveApiModule.py6675192%538–543, 561–564, 566, 667, 720, 898, 901–907, 909, 913, 1021, 1107, 1278, 1280–1287, 1302–1303, 1305–1308, 1352, 1355, 1357, 1359, 1361, 1370, 1377, 1774–1775, 1985, 1987
Packs/ApiModules/Scripts/MicrosoftGraphFilesApiModule
   MicrosoftGraphFilesApiModule.py63512979%129, 134, 140, 186, 195–196, 253–254, 257, 276–281, 283–287, 304–307, 309–323, 462–463, 494–495, 539, 555–557, 581–586, 589, 610–611, 629–630, 645, 883, 911–917, 919, 922–924, 926, 935–936, 938, 941, 943, 964–965, 1088, 1090, 1294, 1371, 1430, 1441, 1450, 1745, 1748–1755, 1758–1788, 1790–1792
Packs/GoogleDrive/Integrations/GoogleDrive
   GoogleDrive.py60100% 
Packs/MicrosoftGraphFiles/Integrations/MicrosoftGraphFiles
   MicrosoftGraphFiles.py60100% 
TOTAL131418086% 

Tests Skipped Failures Errors Time
60 0 💤 0 ❌ 0 🔥 10.290s ⏱️

@content-bot

This comment has been minimized.

Sign in to view
@content-bot

This comment has been minimized.

Sign in to view
@JudahSchwartz JudahSchwartz added ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jul 5, 2026
@JudahSchwartz

JudahSchwartz commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

@marketplace-ai-reviewer start review

@marketplace-ai-reviewer

marketplace-ai-reviewer commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@content-bot

This comment has been minimized.

Sign in to view
@tcarmeli1 tcarmeli1 added the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Jul 5, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Jul 5, 2026
@marketplace-ai-reviewer

marketplace-ai-reviewer commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer

marketplace-ai-reviewer commented Jul 5, 2026

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer
marketplace-ai-reviewer reviewed Jul 5, 2026
View reviewed changes

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment •
edited by tcarmeli1
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting your PR!
Before moving on with the detailed review, please take a moment to address the following general comments.

  • The PR title 'refactor to apimodule' is too generic and the description is empty. Please update the title and description to specify that the refactoring applies to the Google Drive and Microsoft Graph Files integrations, and mention the creation of the new Standard Connector satellite packs for both.

Then re-trigger the content-ai-reviewer.

@content-bot

content-bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This PR was automatically updated by a GitHub Action

  • ApiModules pack version was bumped to 2.4.33.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot

content-bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Validate summary
The following errors were reported as warnings: BC117.
BC117 validation requires PM review due to changes to supportedModules.
The following errors were thrown as a part of this pr: GR107.
The following errors can be ignored: GR107.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: GR107.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

content-bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: 415af96ec8260a17

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

@JudahSchwartz

JudahSchwartz commented Jul 5, 2026 •
edited by BarGali
Loading

Copy link
Copy Markdown
Contributor Author

need force merge due to: check for added large files - fails in precommit - file was moved but not added
the deprecated playbook references are pre-existing

BC117 - thrown but modules are same, just added to the new apimodule

@JudahSchwartz JudahSchwartz added the ForceMerge Forcing the merge of the PR despite the build status label Jul 5, 2026
@JudahSchwartz JudahSchwartz changed the title refactor to apimodule refactor msft, googledrive to apimodule Jul 5, 2026
@JudahSchwartz

JudahSchwartz commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

@marketplace-ai-reviewer start review

@JudahSchwartz

JudahSchwartz commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@marketplace-ai-reviewer re-review

@marketplace-ai-reviewer

marketplace-ai-reviewer commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@JudahSchwartz
JudahSchwartz merged commit 841fb32 into master Jul 6, 2026
42 of 51 checks passed
@JudahSchwartz
JudahSchwartz deleted the standard_msft_gdrive branch July 6, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marketplace-ai-reviewer marketplace-ai-reviewer marketplace-ai-reviewer left review comments
@noydavidi noydavidi noydavidi approved these changes
@Shellyber Shellyber Awaiting requested review from Shellyber Shellyber is a code owner

Assignees

No one assigned

Labels

docs-approved ForceMerge Forcing the merge of the PR despite the build status ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines supported-modules-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JudahSchwartz @content-bot @marketplace-ai-reviewer @noydavidi @tcarmeli1