Gravityzone#44933
Conversation
…sponse and in context.
… with get task status response.
…s command changed as standard command.
This reverts commit 7088c4b.
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/ansimionescu-bd_gravityzone
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed. |
|
Hi @ansimionescu-bd, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
🤖 AI-Powered Code Review AvailableHi @kamalq97, you can leverage AI-powered code review to assist with this PR! Available Commands:
|
content-bot
added
Partner-Approved
Contribution Form Filled
kamalq97
added
ready-for-instance-test
|
For the Reviewer: Trigger build request has been accepted for this contribution PR. |
|
For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/10676628 |
content-bot
removed
the
ready-for-instance-test
marketplace-ai-reviewer
removed
the
ready-for-ai-review
|
🤖 Analysis started. Please wait for results... |
|
Validate summary Verdict: PR can be force merged from validate perspective? ❌ |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi there, thanks for your contribution to the GravityZone integration! I've reviewed the PR and noted a few adjustments needed for security, error handling, and documentation. Please ensure @logger decorators are removed from functions handling sensitive credentials, use safe dictionary access (like .get() or []) to prevent TypeErrors, and update the YAML/README to follow XSOAR formatting standards. Great work overall—just remember to bump the minor version in the release notes and avoid hardcoded IDs in the test playbook!
Additionally, please address the following file-level notes:
Packs/GravityZone/Integrations/GravityZone/GravityZone.yml: Please ensure that theREADME.mdfile is updated to document the new commands (gz-endpoint-users-loggedin,gz-endpoint-create-memory-dump,gz-endpoint-memory-dump-status) and their outputs. XSOAR guidelines require the README to be synchronized with YML changes.Packs/GravityZone/ReleaseNotes/1_0_2.md: The version bump should be a minor bump rather than a revision (patch) bump.
@kamalq97 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
kamalq97
merged commit 0197d27
into
demisto:contrib/ansimionescu-bd_gravityzone
|
Thank you for your contribution. Your external PR has been merged and the changes are now included in one or more internal PRs for further review. Note Contributions containing XSIAM content (Modeling Rules, Parsing Rules, Correlation Rules, or Dashboards) are subject to an additional review process and may take longer to be merged to master. |
* Gravityzone (#44933) * Added gz-endpoint-users-loggedin command * Fixed replacement of entire GravityZone.Endpoint object * Added gz-endpoint-create-memory-dump command. * Fixed replacement of entire GravityZone.Endpoint object * Updated gz-endpoint-create-memory-dump command with more fields as response and in context. * gz-endpoint-create-memory-dump command response updated to be similar with get task status response. * Playbook test updated. * Playbook elements positions updated. * Updated documentation and release notes * Updated documentation for gz-endpoint-create-memory-dump command * Increase polling timeout for memory dump. * Polling option added for memory dump commands. * Descriptions updated for memory dump commands. Also memory dump status command changed as standard command. * Test data added for memory dump status command. * Output updated for memory dump status command and type checking for task types. * Fixed tests and updated release notes * Return error response when task has no type * Updated README * Tests added for none task type. * Updated README * Playbook GravityZone updated with all memory dump commands. * Command examples updated. * If invalid endpoint id provided, display specific error. * Fixed duration for gz-endpoint-create-memory-dump command * Revert "Fixed duration for gz-endpoint-create-memory-dump command" This reverts commit 7088c4b. * Updated note * Fixed incident status mapping * Updated documentation, release notes, texts * Updated documentation * Applied code review suggestions * Changed command format to bold italic --------- Co-authored-by: ilazar-bd <ilazar@bitdefender.com> * Update .pack-ignore --------- Co-authored-by: ansimionescu-bd <ansimionescu@bitdefender.com> Co-authored-by: ilazar-bd <ilazar@bitdefender.com> Co-authored-by: Kamal Qarain <kqarain@paloaltonetworks.com>
5 participants
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Description
Added new commands to the GravityZone integration: gz-endpoint-create-memory-dump command, which initiates a memory dump on the specified endpoint, the gz-endpoint-memory-dump-status command, which verifies the status of a task initiated via gz-endpoint-create-memory-dump and the gz-endpoint-users-loggedin command, which retrieves details of all active user sessions on a specific managed endpoint.
Must have
relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-17220