Skip to content

[Slack - mirror-investigation] Preserve existing mirror autoclose and…#44934

Merged
mmhw merged 2 commits into
masterfrom
MW/XSUP-70395/fix-mirror-investigation-type-arg
Jul 2, 2026
Merged

[Slack - mirror-investigation] Preserve existing mirror autoclose and…#44934
mmhw merged 2 commits into
masterfrom
MW/XSUP-70395/fix-mirror-investigation-type-arg

Conversation

@mmhw

@mmhw mmhw commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: XSUP-70395

Description

  • Fixed an issue where running the mirror-investigation command on an existing mirror changed the autoclose and mirrorTo values under certain conditions instead of preserving the values stored in the context.

Must have

  • Tests
  • Documentation

… mirrorTo when only combined type arg is provided
@mmhw mmhw self-assigned this Jul 2, 2026
@mmhw mmhw requested a review from omerKarkKatz as a code owner July 2, 2026 09:57
@mmhw mmhw added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Jul 2, 2026
@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@mmhw

mmhw commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@marketplace-ai-reviewer start review

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Slack/Integrations/SlackV3
   SlackV3.py193045176%145, 172, 174–178, 180, 198–200, 212, 226, 230, 268, 281, 293, 302, 339, 363–365, 376, 386, 407, 410, 436, 438, 440–442, 445–446, 448–452, 455–456, 459–460, 463–464, 467, 469–470, 473–476, 478, 481–482, 485–488, 490–492, 533, 588–589, 596–607, 609–612, 614, 617–618, 624–625, 635–636, 638, 711, 737, 874–875, 877–879, 881–884, 886, 902, 910–911, 970, 1027–1028, 1061, 1071, 1075–1086, 1107, 1174–1179, 1190–1197, 1205, 1224, 1230, 1263–1264, 1311, 1344, 1347, 1367–1368, 1374–1380, 1383–1384, 1386–1398, 1400–1403, 1437–1438, 1463–1472, 1496, 1508, 1579–1580, 1583–1584, 1587–1588, 1591–1592, 1595–1596, 1599–1600, 1602, 1609–1614, 1621, 1624–1628, 1630–1635, 1637–1642, 1652–1653, 1660–1667, 1700–1701, 1773, 1794, 1800, 1852, 1862–1863, 1957, 2011, 2015–2016, 2057, 2067–2068, 2077, 2107, 2184–2186, 2188, 2195–2199, 2207, 2218, 2233–2234, 2237–2241, 2244–2245, 2248–2252, 2256–2262, 2265–2271, 2284–2285, 2335, 2342–2344, 2418–2419, 2443, 2478, 2481, 2506–2507, 2511, 2522, 2536, 2541–2542, 2574–2575, 2586–2587, 2610, 2627, 2705, 2753–2754, 2757, 2761, 2771, 2774–2776, 2781, 2784, 2828, 2831, 2834, 2841–2842, 2844, 2867, 2870–2871, 2946, 3078, 3103–3106, 3108, 3110–3111, 3113, 3117–3119, 3123–3125, 3127–3128, 3130–3131, 3133, 3135, 3137–3138, 3148, 3164, 3188, 3198, 3200, 3205–3206, 3241–3242, 3248, 3250, 3254, 3263, 3266–3268, 3276–3277, 3279, 3302–3303, 3309, 3333, 3338–3341, 3343, 3423–3425, 3427–3428, 3432, 3484, 3488–3489, 3493, 3501, 3511, 3513, 3533–3537, 3596–3597, 3599, 3601, 3643–3646, 3648–3653, 3724, 3747, 3749–3752, 3754–3755, 3757–3758, 3761–3762, 3785–3788, 3792–3798, 3835–3837, 3850–3851, 3860, 3900–3904, 3913
TOTAL193045176% 

Tests Skipped Failures Errors Time
182 3 💤 0 ❌ 0 🔥 14.686s ⏱️

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the Slack integration! I've reviewed the PR and left a few suggestions to help polish the updates.

The main points to address are adding a unit test for the new logic branch, optimizing dictionary and argument access in the Python code, and a minor formatting tweak in the release notes.

Keep up the great work!

@omerKarkKatz, @mmhw please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/Slack/Integrations/SlackV3/SlackV3.py Outdated
Comment thread Packs/Slack/Integrations/SlackV3/SlackV3.py Outdated
Comment thread Packs/Slack/ReleaseNotes/3_8_6.md Outdated
@content-bot

Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: success
Report ID: e7459e56f0a047a2

📋 Triage Report

⚠️ AI-generated triage. Validate before acting.

Comment thread Packs/Slack/Integrations/SlackV3/SlackV3.py
@mmhw mmhw enabled auto-merge (squash) July 2, 2026 14:34
@mmhw mmhw merged commit 8bdff50 into master Jul 2, 2026
29 of 30 checks passed
@mmhw mmhw deleted the MW/XSUP-70395/fix-mirror-investigation-type-arg branch July 2, 2026 14:36
socautomator pushed a commit to socautomator/content that referenced this pull request Jul 3, 2026
demisto#44934)

* [Slack - mirror-investigation] Preserve existing mirror autoclose and mirrorTo when only combined type arg is provided

* Address PR review: reuse args, safe dict access, RN italics, add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants