Skip to content

XSUP 71435 - ServiceNow Event Collector: order fetch query and lighten Test button to prevent timeouts#44985

Merged
DanielTal87 merged 8 commits into
masterfrom
XSUP-71435
Jul 8, 2026
Merged

XSUP 71435 - ServiceNow Event Collector: order fetch query and lighten Test button to prevent timeouts#44985
DanielTal87 merged 8 commits into
masterfrom
XSUP-71435

Conversation

@dtroushinsky

Copy link
Copy Markdown
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-71435

Description

Adds ORDERBYsys_created_on (ascending) to the ServiceNow Event Collector fetch
query for audit/syslog/case log types to avoid full-table scans and read timeouts
(XSUP-71435), and makes the Test button use a single-record fetch. Includes unit
tests, version bump to 2.9.14, and release notes. The set of collected events is
unchanged; only ordering is now guaranteed.

Must have

  • Tests
  • Documentation

@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@dtroushinsky

Copy link
Copy Markdown
Contributor Author

@marketplace-ai-reviewer start review

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ServiceNow/Integrations/ServiceNowEventCollector
   ServiceNowEventCollector.py132199%269
TOTAL132199% 

Tests Skipped Failures Errors Time
65 0 💤 0 ❌ 0 🔥 3.337s ⏱️

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@dtroushinsky dtroushinsky added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Jul 8, 2026
@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the ServiceNow pack! I've reviewed the changes and just have a quick note regarding the release notes formatting. Since this is a patch version bump, the entries need to describe bug fixes and start with "Fixed an issue" rather than "Improved". Let me know if you have any questions!

@DanielTal87, @omerKarkKatz, @dtroushinsky please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/ServiceNow/ReleaseNotes/2_9_14.md Outdated
dtroushinsky and others added 2 commits July 8, 2026 10:08
Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com>
@dtroushinsky
dtroushinsky enabled auto-merge (squash) July 8, 2026 08:18
@content-bot

Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@DanielTal87
DanielTal87 disabled auto-merge July 8, 2026 16:58
@DanielTal87
DanielTal87 enabled auto-merge (squash) July 8, 2026 16:59
@DanielTal87
DanielTal87 merged commit fe415e7 into master Jul 8, 2026
23 of 25 checks passed
@DanielTal87
DanielTal87 deleted the XSUP-71435 branch July 8, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants