Same-named sub-aspects collide when delivering via provides.to-users

[edoars]

Hit this in my config, where work and science both had a sub-aspect named tools and a package went missing.

Symptom

If two unrelated aspects declare a sub-aspect with the same name, only one applies and the other is dropped.

Repro

test-same-named-sub-aspects = denTest (
  {
    den,
    tuxHm,
    ...
  }:
  {
    den.hosts.x86_64-linux.igloo.users.tux = { };

    den.aspects.igloo.includes = [ den.aspects.alpha den.aspects.beta ];

    den.aspects.alpha = {
      includes = [ den.aspects.alpha.tools ];
      tools.provides.to-users.homeManager.home.sessionVariables.ALPHA = "yes";
    };

    den.aspects.beta = {
      includes = [ den.aspects.beta.tools ];
      tools.provides.to-users.homeManager.home.sessionVariables.BETA = "yes";
    };

    expr = {
      alpha = tuxHm.home.sessionVariables.ALPHA or "<missing>";
      beta = tuxHm.home.sessionVariables.BETA or "<missing>";
    };
    expected = {
      alpha = "yes";
      beta = "yes";
    };
  }
);

Rename beta's sub-aspect to anything else, and both show up.

[sini]

mmmm sounds like the deduplication check isn't preserving the full provenance. I'll take a look.

[sini]

fixed-by: #671