Deno.kill on windows

[VitHavlik]

Version: Deno 2.3.3
OS: Windows 11

Sending a SIGINT OS signal on windows like: Deno.kill(Deno.pid, 'SIGINT');
Results in: TypeError: Windows only supports ctrl-c (SIGINT) and ctrl-break (SIGBREAK), but got SIGINT

Same goes for SIGBREAK

Registering event listeners with: Deno.addSignalListener('SIGINT', doSomething); Works correctly

[Dannynsikak]

can i request to be assigned this issue ,
it's a bit challenging but i can tackle it

[frey-mz]

wondering if there are any workarounds, working on deno 2.4.4 and on my mac (deno 2.4.4 (stable, release, aarch64-apple-darwin) the expected behavior passes, but my coworker is experiencing issues with the stated error message on windows.

[frey-mz]

specifically, getting the exact same issue but with child processes
const command = Deno.Command(...) const proc = command.spawn();

proc.kill("SIGINT") or proc.kill() both give the TypeError: Windows only supports ctrl-c (SIGINT) and ctrl-break (SIGBREAK) error

[eveffer]

wondering if there are any workarounds, working on deno 2.4.4 and on my mac (deno 2.4.4 (stable, release, aarch64-apple-darwin) the expected behavior passes, but my coworker is experiencing issues with the stated error message on windows.

I was having this issue as well trying to have cross platform support for managing child processes. Here's a workaround I've come up with using taskkill for windows. Note the need to use /f flag to force terminate. This may be specific to my use case but I still havent figured out how to not force it. The /t flag is to terminate any child processes of that pid as well.

async function killProc(proc: Deno.ChildProcess, signal: Deno.Signal) {
  if (!proc.pid) {
    return; // return early if the process has already been killed and doesn't have a pid
  }
  if (Deno.build.os === "windows") {
    // spawn a separate command for windows and pass the pid to kill
    const kill = new Deno.Command("taskkill", {
      args: ["/pid", proc.pid.toString(), "/f", "/t"],
    });
    return await kill.output(); // return early for windows
  }
  // fallback to the default behaviour when not windows
  proc.kill(signal);
  return await proc.status;
}

await killProc(someChildProcess,"SIGINT");

[taras]

@eveffer try this https://github.com/thefrontside/ctrlc-windows, it can help you terminate the process gracefully.

import { ctrlc } from "npm:ctrlc-windows@2.2.0";
let command = new Deno.Command(cmd, options);
let process = command.spawn();

if (Deno.build.os === "windows") {
  // Wrap the kill method to use ctrlc-windows on Windows
  // See: https://github.com/denoland/deno/issues/29599
  const originalKill = process.kill.bind(process);
  process.kill = (signal) => {
    if (signal === "SIGINT") {
      ctrlc(process.pid);
    } else {
      originalKill(signal);
    }
  };
}

I just used it in https://github.com/thefrontside/effection/pull/1031/files#diff-2608d3bd5af09d726fe4183133e684f22d2a52739a65f893e54a170bcabfa578 to make the tests pass on Windows