feat(lsp): add additional logging information#10890
Merged
kitsonk merged 1 commit intodenoland:mainfrom Jun 9, 2021
Merged
Conversation
lucacasonato
approved these changes
Jun 8, 2021
Contributor
lucacasonato
left a comment
lucacasonato
left a comment
There was a problem hiding this comment.
LGTM, is it a feat though?
Contributor
Author
|
It is a change to production, user facing code. Is there a more correct semantic commit message? https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716 |
Contributor
|
Maybe refactor? I never considered debug logs to be a user facing feature, but I guess it makes sense. Anyway not particularly important |
Contributor
Author
Well it isn't refactoring code... it s a change in behaviour. If the change of output of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have had a few issues where users have had strange environment configurations that have lead to confusion when using the LSP. This PR adds some additional logging to provide more information in the extension output channel. It adds the path to the executable and the fully resolved import map and config files.