fix(repl): Fix undefined result colour in cmd#10964
Merged
dsherret merged 2 commits intodenoland:mainfrom Jun 14, 2021
Merged
Conversation
dsherret
commented
Jun 14, 2021
|
|
||
| function dim(str) { | ||
| return run(str, code(2, 22)); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I think it's better that we just don't use dim since it doesn't work in cmd and instead use gray (plus, we're already using gray for the input highlighting). I've removed this, but let me know if I should re-add it.
ry
reviewed
Jun 14, 2021
Member
ry
left a comment
ry
left a comment
There was a problem hiding this comment.
Does it still look ok when terminal is black on white?
Contributor
Author
Yup (cmd):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Command prompt:
Windows terminal:
After
Command prompt:
Windows terminal:
Highlighting for
undefinedin the Rust and JS code now both use "grey" instead of "dim" and "grey".Fixes #9761