chore: Rust 1.85.1 #29412
chore: Rust 1.85.1 #29412
Conversation
tests/unit/rename_test.ts
Outdated
| // see https://github.com/rust-lang/rust/pull/137528 | ||
| // assertThrows( | ||
| // () => { | ||
| // Deno.renameSync(olddir, file); | ||
| // }, | ||
| // Error, | ||
| // "The directory name is invalid", | ||
| // ); |
There was a problem hiding this comment.
Instead of commenting this out, maybe we should revert it back to what it was before? Looks like this test used to be different before Rust 1.85.
ee4c14a#diff-b7856c2634c543995bc8dab9f355ac08fa54e894d1012ebaa349d35d4b64a3feL271
There was a problem hiding this comment.
Instead of commenting this out, maybe we should revert it back to what it was before? Looks like this test used to be different before Rust 1.85.
Thank you for your reply. I compared the previous code and now the existing test cases are duplicated.
deno/tests/unit/rename_test.ts
Lines 263 to 264 in 3de21f1
There was a problem hiding this comment.
Ok, maybe let’s remove this commented out code? It seems unnecessary to keep around now.
There was a problem hiding this comment.
Ok, maybe let’s remove this commented out code? It seems unnecessary to keep around now.
Done, and I was rebase onto main
linbingquan
force-pushed
the
dev-rust-1.85.1
branch
from
80ffeac to
1027d34
Compare
2 participants
Rust 1.85.1 releases: https://github.com/rust-lang/rust/releases/tag/1.85.1
Rust 1.85.1 releases log has
std::fs::renamefix PRDeno.renameSyncAPI error with CI test, Perhaps it is caused by this PR, when I try to upgradeRust 1.86.0orRust 1.87.0Here use CI to test.