fix(check): improve @types/ package resolution for the global resolver
#31868
+1,000
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
changed the title
@types/ package resolution for the global resolver
dsherret
commented
Jan 16, 2026
dsherret
commented
Jan 16, 2026
| let (_, nv) = find_definitely_typed_package( | ||
| types_package_name, | ||
| maybe_package_version, | ||
| snapshot.package_reqs().iter(), |
Member
Author
There was a problem hiding this comment.
Previously we were only looking at top level npm packages, which would mean we wouldn't resolve a whole lot of @types packages. This bug fix should fix a lot of type checking issues with the global resolver.
dsherret
commented
Jan 16, 2026
Member
Author
There was a problem hiding this comment.
It's better to add a real integration test for this one.
dsherret
commented
Jan 16, 2026
| let resolved = deno_path_util::resolve_import(&specifier, referrer)?; | ||
| let ext = MediaType::from_specifier(&resolved).as_ts_extension(); | ||
| return Ok((specifier, Some(ext))); | ||
| } |
Member
Author
There was a problem hiding this comment.
We accidentally weren't resolving some of the files for the built-in @types/node package.
Contributor
|
So cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31697