fix(ext/node): prevent derefencing symlinks on fs.rm
#31886
Merged
+76
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tango992
commented
Jan 20, 2026
| WSAENOTSOCK => "ENOTSOCK", | ||
| ERROR_NOT_SUPPORTED => "ENOTSUP", | ||
| ERROR_BROKEN_PIPE => "EOF", | ||
| ERROR_ACCESS_DENIED => "EPERM", |
Member
Author
There was a problem hiding this comment.
Tango992
commented
Jan 20, 2026
Comment on lines
+538
to
+541
| "parallel/test-fs-rm.js": { | ||
| "darwin": false, | ||
| "windows": false | ||
| }, |
Member
Author
There was a problem hiding this comment.
macos and windows fail on these cases: https://github.com/nodejs/node/blob/v24.12.0/test/parallel/test-fs-rm.js#L513-L562. since it's not related with the issue, I think it's better to solve it on a separate PR
bartlomieju
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31840 and also addresses
prefer-primordialsrule