Skip to content

feat(cli/tsc): show progress bar for TSGO downloads #31893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsherret merged 9 commits into from
Jan 21, 2026
Merged

feat(cli/tsc): show progress bar for TSGO downloads #31893

dsherret merged 9 commits into from
Jan 21, 2026
+21 −10

Conversation

@amyssnippet
Copy link
Contributor

@amyssnippet amyssnippet commented Jan 20, 2026

Fixes #31884

Problem

When using DENO_UNSTABLE_TSGO=1 deno check, users receive no feedback during the TypeScript Go compiler download, making them think the process is stuck or frozen.

Solution

Added two console messages in cli/tsc/go/setup.rs:

  • "Downloading TypeScript Go compiler..." displayed before the download starts
  • "TypeScript Go compiler downloaded successfully." displayed after successful completion

These messages provide clear feedback to users about the download progress without being overly verbose.

Changes

  • Modified cli/tsc/go/setup.rs to add eprintln! messages around the download process
  • Messages are displayed to stderr to avoid interfering with command output
  • No functional changes to the download logic itself

Testing

The changes compile successfully and preserve existing functionality while improving user experience for the experimental TSGO feature.

@amyssnippet
feat: add user feedback for TSGO downloads
f1b38e9 
Add console messages before and after TypeScript Go compiler downloads
to inform users that the download is in progress and has completed.
This prevents users from thinking the process is stuck during long
downloads when using DENO_UNSTABLE_TSGO=1.
@amyssnippet
feat: add user feedback for TSGO downloads
c1c6bbb 
Add console messages before and after TypeScript Go compiler downloads
to inform users that the download is in progress and has completed.
This prevents users from thinking the process is stuck during long
downloads when using DENO_UNSTABLE_TSGO=1.

Use log::info! with colors instead of eprintln! to comply with
clippy linting rules.
@amyssnippet
style: format code with rustfmt
9e62def
@amyssnippet amyssnippet mentioned this pull request Jan 20, 2026
Closed
@sigmaSd
Copy link
Contributor

sigmaSd commented Jan 21, 2026

Thanks for your work, usually deno shows a progress bar for downloads, but personally I think this is ok for now

@amyssnippet
Copy link
Contributor Author

amyssnippet commented Jan 21, 2026

Thanks for your work, usually deno shows a progress bar for downloads, but personally I think this is ok for now

as in the issue, it was clearly mentioned that the user can assume that it may be an internet or machine error while the process is executing, so thats why i guess frm the user end it may or may not be necessary to add this, but still if some changes needed, then let me know

@sigmaSd
Copy link
Contributor

sigmaSd commented Jan 21, 2026

Yes I mean what you did fixes the issue , I just suggested an improvement instead of just logging : downloading tsgo, you can make it show a progress bar while downloading but that can be deferred to another pr in my opinion

@amyssnippet
Copy link
Contributor Author

amyssnippet commented Jan 21, 2026

Yes I mean what you did fixes the issue , I just suggested an improvement instead of just logging : downloading tsgo, you can make it show a progress bar while downloading but that can be deferred to another pr in my opinion

ooh, lemme try this, progress bar would be great

@amyssnippet
Copy link
Contributor Author

amyssnippet commented Jan 21, 2026

hey @sigmaSd , the progress bar is making sense, soon rolling out the update. and thats prettty impressive from an end user case in terms of TUI.

@amyssnippet
style(tsgo): rustfmt after progress bar addition
136859a
@amyssnippet
feat: add progress bar for TSGO downloads
06e7d29 
Add a visual progress bar during TypeScript Go compiler downloads
to provide better user feedback. Uses Deno's existing ProgressBar
infrastructure with DownloadBars style for human-readable download
sizes and progress visualization.

The progress bar shows download progress with format like:
'Download [####----] 5.2MB/20.6MB'

Falls back to log message when progress bars aren't supported
(in non-TTY environments).
@amyssnippet
Copy link
Contributor Author

amyssnippet commented Jan 21, 2026

hey, check this out, i have implemented the progress bar of downloading tsgo while running a ts file requiring tsgo. and so here i have captured a video for the dev moment


Screencast.from.2026-01-21.21-54-58.webm

@amyssnippet
Copy link
Contributor Author

amyssnippet commented Jan 21, 2026

This commit I did was regarding some linting issues in the file i changed

dsherret
dsherret reviewed Jan 21, 2026
View reviewed changes
dsherret and others added 2 commits January 21, 2026 13:45
@dsherret dsherret changed the title feat(cli/tsc): add user feedback for TSGO downloads feat(cli/tsc): show progress bar for TSGO downloads Jan 21, 2026
dsherret
dsherret approved these changes Jan 21, 2026
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret enabled auto-merge (squash) January 21, 2026 18:50
@dsherret dsherret merged commit 0be96f9 into denoland:main Jan 21, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsherret dsherret dsherret approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DENO_UNSTABLE_TSGO=1 deno check should shows feedback when donwloading tsgo

3 participants

@amyssnippet @sigmaSd @dsherret