fix(ext/node): inspector.open() and inspector.close() #31898
Merged
+349
−185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Jan 22, 2026
| .borrow_mut::<PermissionsContainer>() | ||
| .check_net(&(host_ip.to_string(), Some(port)), "inspector.open")?; | ||
|
|
||
| let server = create_inspector_server(addr, "deno")?; |
Member
Author
There was a problem hiding this comment.
The name here doesn't really match the name when --inspect flag or what Node.js displays. This is tested by parallel/test-inspector-contexts.js Node compat test.
littledivy
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds proper support for
node:inspectorAPIs:inspector.open()inspector.close()Also
process.features.inspectorvalue was changed totrue.As a result a bunch of Node compat tests related to inspector started failing -
turns out that these tests never really worked - they passed because they
exited early because of lack of inspector support (due to
process.features.inspectorvalue). These tests were disabled for now.