fix(ext/node): fix AbortController signal handling in child_process s…#32713
Merged
fraidev merged 1 commit intodenoland:mainfrom Mar 14, 2026
Merged
fix(ext/node): fix AbortController signal handling in child_process s…#32713fraidev merged 1 commit intodenoland:mainfrom
fraidev merged 1 commit intodenoland:mainfrom
Conversation
…pawn
Two bugs in the abort listener for child_process.spawn():
1. Hardcoded "SIGKILL" instead of using the killSignal option
(default "SIGTERM"), causing wrong signal to be sent to child.
2. AbortError was created without passing signal.reason as cause,
so controller.abort(new Error('boom')) lost the abort reason.
Also fixes test-child-process-fork-abort-signal.js which had the
same root cause.
bartlomieju
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the abort listener for child_process.spawn():
Hardcoded "SIGKILL" instead of using the killSignal option (default "SIGTERM"), causing wrong signal to be sent to child.
AbortError was created without passing signal.reason as cause, so controller.abort(new Error('boom')) lost the abort reason.
Also fixes test-child-process-fork-abort-signal.js which had the same root cause.