fix(ext/node): allow IPv6 multicast addresses in UDP addMembership/dropMembership#32739
Merged
bartlomieju merged 1 commit intodenoland:mainfrom Mar 15, 2026
Merged
Conversation
8933642 to
5e297e1
Compare
…opMembership The validation was only checking for IPv4 addresses, making the IPv6 code path unreachable. This refactors validation to check addresses based on the socket family - IPv4 sockets validate IPv4 addresses, IPv6 sockets validate IPv6 addresses. Also uses the existing isIP() helper instead of manual octet parsing.
5e297e1 to
9c10261
Compare
bartlomieju
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation in
addMembershipanddropMembershipwas only checking for IPv4 addresses usingisValidIPv4Address(), making the IPv6 code path unreachable:This refactors validation to check addresses based on the socket family:
Also uses the existing
isIP()helper instead of manual octet parsing.