fix(tools): improve dlint binary discovery for cross-architecture support#33129
Open
lu-zero wants to merge 1 commit intodenoland:mainfrom
Open
fix(tools): improve dlint binary discovery for cross-architecture support#33129lu-zero wants to merge 1 commit intodenoland:mainfrom
lu-zero wants to merge 1 commit intodenoland:mainfrom
Conversation
…port - Add architecture-aware target triple detection (x86_64 vs aarch64) - Check for local dlint in PATH with matching version before downloading - Download dlint from GitHub releases with correct arch-specific binary - Add fallback to build dlint from denoland/deno_lint source when no prebuilt is available for the current architecture - Propagate build failures as errors Co-Authored-By: opencode <https://github.com/anomalyco/opencode> Co-Authored-By: zai-org/GLM-5-FP8 <https://modal.com/zai-org/GLM-5-FP8>
lu-zero
force-pushed
the
dlint-on-non-x86-linux
branch
from
1dd2484 to
2f363c9
Compare
Member
|
Can you describe the purpose of this PR? All tools needed to build and test Deno locally are already vendored and I'm not keen on adding fallbacks and multiple paths that only increase maintenance burden. |
Contributor
Author
|
the tools do not work on linux aarch64. |
Contributor
Author
|
denoland/deno_lint#1482 is my alternative solution, but I'd keep the fallback at least to the tools in path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made with glm-5 and opencode.