Skip to content

fix(ext/node): improve https agent compat#34091

Merged
bartlomieju merged 2 commits into
denoland:mainfrom
bartlomieju:fix-node-https-agent-tls-timeouts
May 15, 2026
Merged

fix(ext/node): improve https agent compat#34091
bartlomieju merged 2 commits into
denoland:mainfrom
bartlomieju:fix-node-https-agent-tls-timeouts

Conversation

@bartlomieju
Copy link
Copy Markdown
Member

Summary

  • pass tls.Server handshakeTimeout through to accepted server-side TLSSocket instances
  • normalize https.Agent#createConnection(port[, host][, options][, cb]) call forms without mutating options
  • enable the now-passing Node compat tests for HTTPS agent createConnection and HTTPS handshake timeout

Tests

  • ./x fmt
  • ./x build
  • ./x test-compat test-https-agent-create-connection.js
  • ./x test-compat test-https-timeout-server.js

@bartlomieju bartlomieju changed the title fix(node): improve https agent compat fix(ext/node): improve https agent compat May 15, 2026
@bartlomieju bartlomieju merged commit 1bf75fb into denoland:main May 15, 2026
137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant