Skip to content

feat(cli/coverage): print lines with no coverage to stdout#7640

Merged
ry merged 7 commits intodenoland:masterfrom
caspervonb:feat-cli-coverage-print-out-hunks-with-no-coverage
Sep 23, 2020
Merged

feat(cli/coverage): print lines with no coverage to stdout#7640
ry merged 7 commits intodenoland:masterfrom
caspervonb:feat-cli-coverage-print-out-hunks-with-no-coverage

Conversation

@caspervonb
Copy link
Contributor

This pretty prints uncovered lines as red text with line numbers to stdout with the coverage report.

Screenshot 2020-09-23 at 2 18 39 PM

@caspervonb caspervonb force-pushed the feat-cli-coverage-print-out-hunks-with-no-coverage branch 4 times, most recently from 71f1f22 to 6ca9dec Compare September 23, 2020 06:48
@caspervonb caspervonb force-pushed the feat-cli-coverage-print-out-hunks-with-no-coverage branch from 6ca9dec to 44b85f4 Compare September 23, 2020 06:49
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ry
Copy link
Member

ry commented Sep 23, 2020

Is coverage an unstable feature? Can we land this immediately?

decided to just land it

@ry ry merged commit 6254bd4 into denoland:master Sep 23, 2020
@caspervonb
Copy link
Contributor Author

Yeah its unstable 👍

@caspervonb caspervonb deleted the feat-cli-coverage-print-out-hunks-with-no-coverage branch May 24, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants