feat: add structured cloning to Deno.core#9458
Merged
bartlomieju merged 10 commits intodenoland:masterfrom Feb 16, 2021
inteon:add_serialize_deserialize
Merged
feat: add structured cloning to Deno.core#9458bartlomieju merged 10 commits intodenoland:masterfrom inteon:add_serialize_deserialize
bartlomieju merged 10 commits intodenoland:masterfrom
inteon:add_serialize_deserialize
Conversation
bartlomieju
reviewed
Feb 10, 2021
bartlomieju
reviewed
Feb 10, 2021
Contributor
Author
|
Blocked on #9466 |
bartlomieju
changed the title
bartlomieju
approved these changes
Feb 16, 2021
Member
bartlomieju
left a comment
bartlomieju
left a comment
There was a problem hiding this comment.
LGTM, thanks @inteon, great work!
Before landing I'll wait for Ben's review
bnoordhuis
approved these changes
Feb 16, 2021
| struct SerializeDeserialize {} | ||
|
|
||
| impl v8::ValueSerializerImpl for SerializeDeserialize { | ||
| #[allow(unused_variables)] |
Member
There was a problem hiding this comment.
This function is required by v8::ValueSerializerImpl but is never used in core/bindings.rs (yet I think)
Member
|
Nice work @inteon - thanks! |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step towards #3557, as discussed in #9323. Also includes some simple tests.