docs: fix broken Deno.test.each API reference links#3394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testing guide and the deno test CLI page linked Deno.test.each to
/api/deno/
/Deno.test.each, but the reference generator never emits a page/Deno.DenoTest.each (same pattern as the existingat that URL: each is a property of the DenoTest interface, so its page is
/api/deno/
Deno.DenoTest.beforeEach page). The links now point there, and oldurls.json
redirects the already-published Deno.test.each URL to the right page.
The symbol is also missing from the deployed API reference because it was
generated with a pre-2.9 Deno (the each types landed in 2.9.0). In CI the
lint workflow cached reference_gen/types keyed only on repo files, so the
types produced by
deno typeswere never refreshed when the Deno binarychanged. The workflow now regenerates types on every run and caches only
the doc generation, keyed on the generated types' content. The deployed
reference will pick up the new page on the next build with Deno >= 2.9.
Fixes #3389