fix(examples): register orphan examples in catalog - #3453
Conversation
Avocet review statusState: Completed The formal GitHub review is the authoritative result. This comment only reports operational status. |
avocet-bot
left a comment
There was a problem hiding this comment.
Review model: Claude Opus
Model verdict: APPROVE (informational only)
Formal review policy did not authorize an authoritative event (required_checks_missing).
No blocking findings.
Verified the two new catalog entries in examples/_data.ts are correct: both referenced scripts exist (examples/scripts/sss.ts, examples/scripts/checking_directory_existence.ts), and their hrefs (/examples/sss/, /examples/checking_directory_existence/) match the page URLs generated by examples/index.examples.page.tsx (/examples/${label}/). Both category values are valid members of categoryOrder, so they render in the sidebar (_data.ts:2040). Entry order doesn't matter since items are alphabetized at build time. The @title edit in sss.ts is a JSDoc tag that now matches the catalog label and has no typecheck/runtime impact. Pure data/doc change with no error handling, logic, or test coverage implications.
Avocet review statusState: Completed The formal GitHub review is the authoritative result. This comment only reports operational status. |
avocet-bot
left a comment
There was a problem hiding this comment.
Review model: Claude Opus
Model verdict: APPROVE
No blocking findings. The effective base/head change at current head dd6295f is identical to the previously reviewed change (the new head only merges main into the branch). Re-verified: both catalog entries reference scripts that exist (examples/scripts/sss.ts, examples/scripts/checking_directory_existence.ts); their hrefs (/examples/sss/, /examples/checking_directory_existence/) match the URLs generated by examples/index.examples.page.tsx; both category values are valid members of categoryOrder so they render in the sidebar; and the @title edit in sss.ts is a JSDoc tag now aligned with the catalog label, with no typecheck/runtime impact. No prior findings remain open.
454b57d to
0a64406
Compare
0a64406 to
bd52f16
Compare
Register
Shamir's Secret SharingandChecking for directory existencein the examples catalog so their pages appear in the sidebar/landing page. Also alignssss.ts@titlewith its catalog label.