chore(cache): stop relying on globalThis.gc being untyped - #7253
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7253 +/- ##
========================================
Coverage 95.00% 95.00%
========================================
Files 617 617
Lines 51674 51422 -252
Branches 9326 9277 -49
========================================
- Hits 49093 48855 -238
+ Misses 2038 2029 -9
+ Partials 543 538 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bartlomieju
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deno canary types
globalThis.gc, so the@ts-expect-errorabove it is now unused anddeno testfails with TS2578. ReadinggcthroughReflect.getworks on both stable and canary, and keeps the test honest aboutgcbeing optional.Partly solves #7219. The other 24 canary errors are a Deno-side
URLPatterntype collision, filed separately: denoland/deno#36346Tested on 2.9.3 and canary 2.9.4+41e97d3, including
deno test --v8-flags="--expose-gc" cache/