Merged
Conversation
Member
Author
|
I have really good timing, the bundler test is failing not because of this change: https://github.com/dependabot/smoke-tests/actions/runs/3483487230 |
Member
|
Next time, can you squash your fixup commits like "silly lint" "missing error type" etc to keep the history cleaner? |
Member
Author
|
They're squashed on main, I used the squash button. |
Member
|
Oh thanks, I totally overlooked that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pavera is developing a smoke test for the Yarn Berry ecosystem which caches binaries by default.
This has rendered the diff view in the CLI useless, and actually a hinderance as I ran his test and the amount of output to stdout caused the updater to timeout!
Also the comparison of the expected and actual is slightly busted since it compares data we've unmarshalled into our model with the raw JSON coming in from a request. This has the result of some Go-isms (like default value vs null) being applied to one side and not the other.
Originally I did it this way because I was afraid our model was off, which we found in time that it was. Now that things are settling I have more confidence, but I've also added a line to the YAML decoder which will error if an unexpected value is encountered.
So this PR:
In the future I want to bring the diff output back but have it smart about what type it's diffing, which is why I broke out the different compare functions. I'll fill those in in the future!