Skip to content

Run update-ca-certificates also when debug flag is present #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ByAgenT merged 2 commits into from
Sep 2, 2025
+7 −7
Merged

Run update-ca-certificates also when debug flag is present #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fd97d0
Run update-ca-certificates also when debug flag is present.
ByAgenT Sep 2, 2025
c57250c
Do not call update-ca-certs when starting debug shell
ByAgenT Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions internal/infra/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,17 +451,17 @@ func runContainers(ctx context.Context, params RunParams) (err error) {
}
}

// update CA certificates as root prior to start debug shell or running dependabot commands
if err := updater.RunCmd(ctx, "update-ca-certificates", root); err != nil {
return err
}

if params.Debug {
if err := updater.RunShell(ctx, prox.url, params.ApiUrl, params.Job, params.UpdaterEnvironmentVariables); err != nil {
return err
}
} else {
// First, update CA certificates as root
if err := updater.RunCmd(ctx, "update-ca-certificates", root); err != nil {
return err
}

// Then run the dependabot commands as the dependabot user
// Run dependabot commands as a dependabot user
env := userEnv(prox.url, params.ApiUrl, params.Job, params.UpdaterEnvironmentVariables)
if params.Flamegraph {
env = append(env, "FLAMEGRAPH=1")
Expand Down
2 changes: 1 addition & 1 deletion internal/infra/updater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ func (u *Updater) RunShell(ctx context.Context, proxyURL string, apiUrl string,
Tty: true,
User: dependabot,
Env: append(userEnv(proxyURL, apiUrl, job, additionalEnvVars), "DEBUG=1"),
Cmd: []string{"/bin/bash", "-c", "update-ca-certificates && /bin/bash"},
Cmd: []string{"/bin/bash"},
})
if err != nil {
return fmt.Errorf("failed to create exec: %w", err)
Expand Down