cleanup the "update" subcommand #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landongrindheim
approved these changes
Mar 17, 2023
Contributor
landongrindheim
left a comment
landongrindheim
left a comment
There was a problem hiding this comment.
👍 This makes sense to me!
Comment on lines
-59
to
+60
| Run the `update` subcommand with the `--dry-run` flag to | ||
| simulate a Dependabot update job for the provided ecosystem and repo | ||
| (without actually creating any PRs). | ||
| Run the `update` subcommand to run a Dependabot update job for the provided ecosystem and repo. | ||
| This does not create PRs, but outputs data that could be used to create PRs. |
Contributor
There was a problem hiding this comment.
Should we consider using a flag to do the inverse of --dry-run? i.e. use a --execute flag or something to create pull requests?
Member
Author
There was a problem hiding this comment.
Yeah if we go that route, I would rather it be a flag that enables the PR management, rather than defaulting to it and needing to remember to add the dry-run flag.
Contributor
There was a problem hiding this comment.
I would rather it be a flag that enables the PR management, rather than defaulting to it and needing to remember to add the dry-run flag
That seems right on target to me 🎯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few small things to improve the update command: