Ignore any calls to increment_metric as irrelevant#93
Merged
Conversation
landongrindheim
approved these changes
Apr 6, 2023
Collaborator
Author
|
@jakecoffman I was 50/50 on that, I was thinking of it mostly as 'I'm not sure anyone but us cares about instrumentation', but I guess their information is likely useful to have in the logs? |
Member
|
I would only be concerned that someone is confused why isn't working since it's eating it quietly instead of eating it loudly. |
Collaborator
Author
proxy | 2023/04/06 14:05:59 [008] 200 http://host.docker.internal:57761/update_jobs/cli/update_dependency_list
proxy | 2023/04/06 14:05:59 [009] POST http://host.docker.internal:57761/update_jobs/cli/increment_metric
{"data":{"metric":"updater.started","tags":{"operation":"Dependabot::Updater::Operations::UpdateAllVersions"}},"type":"increment_metric"}
proxy | 2023/04/06 14:05:59 [009] 200 http://host.docker.internal:57761/update_jobs/cli/increment_metric
updater | 2023/04/06 14:05:59 INFO Starting update job for rsc/quote@jakecoffman I've updated it to output the data, I think it makes more sense. I'll need to tweak the value of the |
Member
|
LGTM looks like it just needs a run through the Go formatter. |
efbb285 to
d35a483
Compare
jakecoffman
reviewed
Apr 6, 2023
d35a483 to
a7a009a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title, we don't need to handle or set expectations on these calls.