harden helm cache and shared cmd helpers - #58
Merged
Conversation
- inject per-client ChartCache and typed helm error wrapping - surface stale deploy watcher status and use WithoutCancel - rename common to cmdopts and util to validate - harden shell executor quoting and add unit tests
github-actions
Bot
added
area/cli
atkrad
added
the
kind/chore
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- cover refreshPodStatus stale/cancel paths and finalRefresh success - exercise ChartCache expiry, cleanup, and createChartCopy - extract startTerminalResizeWatch for unit-tested SIGWINCH lifecycle
- shrink final refresh waits in tests via package vars - exercise deadline warning path and terminal resize signal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChartCache, classify Helm/Kubernetes errors with typed checks, and show stale deploy-watcher status (withcontext.WithoutCancelfor final refresh).internal/cmd/commontocmdoptsandinternal/utiltovalidate; tighten cluster unreachable detection.Test plan
scenarios/(if behavior changes)nix run .#lint/ pre-commit cleanLabels
kind/feature,kind/bug,kind/docs,kind/chorebreaking-changeif this breaks existing CLI or config behaviorskip-changelogfor internal-only PRs that should not appear in notesChecklist
README.md,docs/cli/)