test: characterize single Grafana module rendering - #71
Draft
lokeshmuvva wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First step of AWS ECS Fargate support. This PR is groundwork only — it adds test coverage and changes no runtime behavior.
Adds
tests/test_template_rendering.py, a characterization test asserting the Grafana module is emitted exactly once by thecloud_runtemplate. This locks in the fix from #62 so the AWS work can't silently regress it.Why this first
The AWS plan requires existing GCP behavior to stay green throughout. There was no test guarding that, so this establishes the baseline before any provider abstraction lands.
The test defines its fixture inline rather than adding
tests/conftest.py, deliberately:conftest.pyis one of the files #63 also adds, and there's no reason to contest it for one fixture.Known gap, fixed in the next commit
cli.pyselectsmlflow_main.tf.j2whenever the stack contains MLflow — which the documented stack always does — so this test currently guards a template the documented stack doesn't render. The follow-up extends the same assertion tomlflow_main.tf.j2. Flagging it here rather than quietly shipping partial coverage.What's coming on this branch
AWS support lands incrementally on this PR: provider config validation and seams, then the AWS Terraform foundation (VPC/RDS/S3/ECS), the database bootstrap container, and MLflow/FastAPI/Grafana on Fargate. Tasks touching
cli.py,doctor.py, andinfracost.pyare sequenced behind #64 to avoid conflicting with the Infracost v2 work.Test plan
pytest tests/ -v— 64 passedmain, conflict-free, suite still greencloud_runbehavior