Skip to content

test: characterize single Grafana module rendering - #71

Draft
lokeshmuvva wants to merge 4 commits into
mainfrom
lokesh/aws
Draft

test: characterize single Grafana module rendering#71
lokeshmuvva wants to merge 4 commits into
mainfrom
lokesh/aws

Conversation

@lokeshmuvva

Copy link
Copy Markdown
Member

Summary

First step of AWS ECS Fargate support. This PR is groundwork only — it adds test coverage and changes no runtime behavior.

Adds tests/test_template_rendering.py, a characterization test asserting the Grafana module is emitted exactly once by the cloud_run template. This locks in the fix from #62 so the AWS work can't silently regress it.

Why this first

The AWS plan requires existing GCP behavior to stay green throughout. There was no test guarding that, so this establishes the baseline before any provider abstraction lands.

The test defines its fixture inline rather than adding tests/conftest.py, deliberately: conftest.py is one of the files #63 also adds, and there's no reason to contest it for one fixture.

Known gap, fixed in the next commit

cli.py selects mlflow_main.tf.j2 whenever the stack contains MLflow — which the documented stack always does — so this test currently guards a template the documented stack doesn't render. The follow-up extends the same assertion to mlflow_main.tf.j2. Flagging it here rather than quietly shipping partial coverage.

What's coming on this branch

AWS support lands incrementally on this PR: provider config validation and seams, then the AWS Terraform foundation (VPC/RDS/S3/ECS), the database bootstrap container, and MLflow/FastAPI/Grafana on Fargate. Tasks touching cli.py, doctor.py, and infracost.py are sequenced behind #64 to avoid conflicting with the Infracost v2 work.

Test plan

  • pytest tests/ -v — 64 passed
  • Rebased onto current main, conflict-free, suite still green
  • Reviewer confirms the characterization matches intended cloud_run behavior

@lokeshmuvva
lokeshmuvva requested a review from tomtranjr July 28, 2026 23:26
@tomtranjr
tomtranjr marked this pull request as draft July 28, 2026 23:31
@tomtranjr tomtranjr assigned lokeshmuvva and unassigned tomtranjr Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants