billing: upload slip + WHT cert together via Pay (no dead-end attach) - #333
Merged
Conversation
The invoice page showed "Attach WHT certificate" for open company invoices. That endpoint requires an existing transfer slip, so customers who still needed to pay got "upload your payment slip before attaching a withholding tax certificate" instead of uploading both files in one step. Show the page-level attach button only after the invoice was paid with withholding (late 50 ทวิ). On open invoices, slip + optional cert ride together on billing.uploadTransferSlip in the Pay modal. Prompter: ACS
|
Preview deleted (PR closed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
billing.uploadWHTCertificate, which requires an existing transfer slip, so customers who still needed to pay hitapi: upload your payment slip before attaching a withholding tax certificate.withholdingTaxAmount > 0).billing.uploadTransferSlipin the Pay modal (existing behavior).Test plan
tests/billing.spec.jsWHT cases)Requested via Grok Work
Prompter: ACS