Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

fix: add node version restriction#14

Merged
marcysutton merged 1 commit intodequelabs:masterfrom
stefanjudis:patch-1
May 2, 2017
Merged

fix: add node version restriction#14
marcysutton merged 1 commit intodequelabs:masterfrom
stefanjudis:patch-1

Conversation

@stefanjudis
Copy link
Copy Markdown
Contributor

When running axe-cli in in node version smaller than 6 (this is a least what I tested) it throws the following error:

> axe https://www.stefanjudis.de
/Users/stefanjudis/.nvm/versions/node/v5.12.0/lib/node_modules/axe-cli/node_modules/selenium-webdriver/index.js:115
  static createSession(...args) {}
                       ^^^

SyntaxError: Unexpected token ...
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/stefanjudis/.nvm/versions/node/v5.12.0/lib/node_modules/axe-cli/lib/axe-test-urls.js:3:19)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)

To help future users it might make sense to define a proper version, so that npm could potentially warn the user.

When running `axe-cli` in in node version smaller than 6 (this is a least what I tested) it throws the following error:

```
> axe https://www.stefanjudis.de
/Users/stefanjudis/.nvm/versions/node/v5.12.0/lib/node_modules/axe-cli/node_modules/selenium-webdriver/index.js:115
  static createSession(...args) {}
                       ^^^

SyntaxError: Unexpected token ...
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/stefanjudis/.nvm/versions/node/v5.12.0/lib/node_modules/axe-cli/lib/axe-test-urls.js:3:19)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
```

To help future users it might make sense to define a proper version, so that npm could potentially warn the user.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 23, 2017

CLA assistant check
All committers have signed the CLA.

@marcysutton
Copy link
Copy Markdown
Contributor

We do mention it in the README. It doesn't really warn users when they install it though, only if axe-cli is included as a dependency.

From npm:

Unless the user has set the engine-strict config flag, this field is advisory only will produce warnings when your package is installed as a dependency.

We also recommend installing axe-cli globally, so I'm not sure how useful this is. Probably doesn't hurt, though.

@marcysutton marcysutton merged commit b9ff463 into dequelabs:master May 2, 2017
@stefanjudis stefanjudis deleted the patch-1 branch May 3, 2017 07:26
@stefanjudis
Copy link
Copy Markdown
Contributor Author

stefanjudis commented May 3, 2017

Whooops. Yeah, didn't read that, sorry. :)

But yeah - won't hurt I guess. Thanks for merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants