This repository was archived by the owner on Mar 19, 2021. It is now read-only.
fix: add node version restriction#14
Merged
marcysutton merged 1 commit intodequelabs:masterfrom May 2, 2017
stefanjudis:patch-1
Merged
fix: add node version restriction#14marcysutton merged 1 commit intodequelabs:masterfrom stefanjudis:patch-1
marcysutton merged 1 commit intodequelabs:masterfrom
stefanjudis:patch-1
Conversation
When running `axe-cli` in in node version smaller than 6 (this is a least what I tested) it throws the following error: ``` > axe https://www.stefanjudis.de /Users/stefanjudis/.nvm/versions/node/v5.12.0/lib/node_modules/axe-cli/node_modules/selenium-webdriver/index.js:115 static createSession(...args) {} ^^^ SyntaxError: Unexpected token ... at exports.runInThisContext (vm.js:53:16) at Module._compile (module.js:387:25) at Object.Module._extensions..js (module.js:422:10) at Module.load (module.js:357:32) at Function.Module._load (module.js:314:12) at Module.require (module.js:367:17) at require (internal/module.js:20:19) at Object.<anonymous> (/Users/stefanjudis/.nvm/versions/node/v5.12.0/lib/node_modules/axe-cli/lib/axe-test-urls.js:3:19) at Module._compile (module.js:413:34) at Object.Module._extensions..js (module.js:422:10) ``` To help future users it might make sense to define a proper version, so that npm could potentially warn the user.
Contributor
|
We do mention it in the README. It doesn't really warn users when they install it though, only if axe-cli is included as a dependency. From npm:
We also recommend installing axe-cli globally, so I'm not sure how useful this is. Probably doesn't hurt, though. |
Contributor
Author
|
Whooops. Yeah, didn't read that, sorry. :) But yeah - won't hurt I guess. Thanks for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
axe-cliin in node version smaller than 6 (this is a least what I tested) it throws the following error:To help future users it might make sense to define a proper version, so that npm could potentially warn the user.