Fix issue with multiple suffixes and capitalization - #15
Merged
Conversation
As mentioned in #14, when the nameparser is passed a name like "SAHNI, ARU MD PHD", the suffix property is joined by a comma and a space. When `capitalize()` is called, the `HumanName.suffix` property is only split on space, resulting in trailing commas in the first n-1 `suffix_list` entries. fixes #14
derek73
added a commit
that referenced
this pull request
Jun 3, 2014
Fix issue with multiple suffixes and capitalization
Owner
|
Thanks for the report and fix. Merged into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #14, when the nameparser is passed a name like "SAHNI, ARU MD PHD", the suffix property is joined by a comma and a space. When
capitalize()is called, theHumanName.suffixproperty is only split on space, resulting in trailing commas in the first n-1suffix_listentries.fixes #14