Small parser cleanups#231
Merged
Merged
Conversation
str.split(" ") always returns a non-empty list, so the
`len(parts) and isinstance(parts, list)` guard could never be false.
titles and suffixes are already lists; len(list(...)) just re-wraps them. Use plain truthiness instead.
Calling the dunder directly bypasses the normal str() protocol for no reason.
Extra spaces before '=' were added to align the assignments; drop them to match normal style.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
==========================================
- Coverage 97.29% 97.29% -0.01%
==========================================
Files 13 13
Lines 814 813 -1
==========================================
- Hits 792 791 -1
Misses 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #229.
Bundle of trivial cleanups, one PR with a commit per item:
_process_initial(str.split(" ")always returns a non-empty list)len(list(titles))/len(list(suffixes))inparse_piecesto plain truthinessfull_nameproperty now callsstr(self)instead ofself.__str__()=assignment spacing in__init__Test plan
python -m pytest -q— 1340 passed, 4 skipped, 22 xfailed