Skip to content

feat: Rename the card to advanced-camera-card - #1873

Merged
dermotduffy merged 2 commits into
mainfrom
rename
Feb 7, 2025
Merged

feat: Rename the card to advanced-camera-card#1873
dermotduffy merged 2 commits into
mainfrom
rename

Conversation

@dermotduffy

@dermotduffy dermotduffy commented Feb 6, 2025

Copy link
Copy Markdown
Owner

Whilst the Frigate support in this card is the best among camera engines, the name incorrectly suggests that Frigate is a requirement. Instead, to broaden the appeal, change to more camera agnostic name. This does not suggest any change in priority, role or support for Frigate.

This change is likely to be bug prone, due to the size of the rename -- the code contains 1500+ references to "Frigate" most of which make sense to rename, some which do not, all of which needed human assessment.

BREAKING CHANGE: References to frigate-card in all kinds of configuration need to be updated to advanced-camera-card. An automated config upgrade should take care of the majority of usecases (click Edit -> Upgrade -> Save), though may not be perfect.

Whilst the Frigate support in this card is the best among camera engines, the name incorrectly suggests that Frigate is a requirement. Instead, to broaden the appeal, change to more camera agnostic name. This does not suggest any change in priority, role or support for Frigate.

This change is likely to be bug prone, due to the size of the rename -- the code contains 1500+ references to "Frigate" most of which make sense to rename, some which do not, all of which needed human assessment.

- Closes #1298

BREAKING CHANGE: References to `frigate-card` in all kinds of configuration need to be updated to `advanced-camera-card`. An automated config upgrade should take care of the majority of usecases (click Edit -> Upgrade -> Save), though may not be perfect.
@github-actions github-actions Bot added the refactoring Refactoring label Feb 6, 2025
@dermotduffy dermotduffy changed the title refactor: Rename the card to advanced-camera-card feat: Rename the card to advanced-camera-card Feb 6, 2025
@github-actions github-actions Bot added feature New feature or request and removed refactoring Refactoring labels Feb 6, 2025
@felipecrs

Copy link
Copy Markdown
Contributor

Exciting!

@dermotduffy
dermotduffy merged commit cc376a8 into main Feb 7, 2025
@github-actions

github-actions Bot commented Feb 7, 2025

Copy link
Copy Markdown

🎉 This issue has been resolved in version 7.0.0 🎉

See: GitHub release

@felipecrs

felipecrs commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

One suggestion is to first remove the card from HACS, reload HACS, and then install it again rather than updating it. Otherwise, it will not remove some leftovers.

chrome_Tm31T8bemQ.mp4

@felipecrs

Copy link
Copy Markdown
Contributor

But according to my tests, the following still needs to be removed manually:

image

@kohbo

kohbo commented Feb 12, 2025

Copy link
Copy Markdown

One suggestion is to first remove the card from HACS, reload HACS, and then install it again rather than updating it. Otherwise, it will not remove some leftovers.
chrome_Tm31T8bemQ.mp4

I did this but HACS still says the resource will be located at frigate-hass-card

@felipecrs

felipecrs commented Feb 12, 2025

Copy link
Copy Markdown
Contributor

Have you reloaded HACS? Restarting Home Assistant should also do the trick.

@kohbo

kohbo commented Feb 12, 2025

Copy link
Copy Markdown

Have you reloaded HACS? Restarting Home Assistant should also do the trick.

After restarting HASS and then removing and adding the card again it now shows the right path. Thanks!

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 15, 2025
@dermotduffy
dermotduffy deleted the rename branch December 9, 2025 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New feature or request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meta: Should this card be renamed?

3 participants