Add support for salt in import with sha passwords#319
Merged
Conversation
|
🐕 Review complete — View session on Shuni Portal 🐾 |
aviadl
approved these changes
Apr 20, 2026
![shuni-bot-dev[bot]](https://avatars.githubusercontent.com/u/97479186?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Adds client-side support for importing users with salted SHA password hashes by extending the batch-user password model and validating the behavior via a functional test.
Changes:
- Extend
BatchUserPasswordSharequest model to include asaltfield. - Add a functional test that creates a user via batch import using
sha256+salt, then signs in with the plaintext password.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/java/com/descope/model/user/request/BatchUserPasswordSha.java |
Adds salt to the SHA hashed-password payload model. |
src/test/java/com/descope/sdk/mgmt/impl/UserServiceImplTest.java |
Adds a functional test covering batch import with salted SHA password hashes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Related to https://github.com/descope/etc/issues/14870
Description
Add support for salted sha passwords when importing users
Must