fix(tenant): correct TenantSettings type to match proto API#722
fix(tenant): correct TenantSettings type to match proto API#722
Conversation
Renames `sessionSettingsEnabled` to `enabled` to match the `ConfigureTenantSettingsRequest` proto field — the old name was silently ignored by the API. Also adds the missing `ssoSetupSuiteSettings` field and its supporting types (`SSOSetupSuiteSettings`, `SSOSetupSuiteSettingsDisabledFeatures`). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
![shuni-bot-dev[bot]](https://avatars.githubusercontent.com/u/97479186?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
Fixes TenantSettings.sessionSettingsEnabled → enabled to match the proto API (the old name was silently ignored), and adds the missing ssoSetupSuiteSettings field with its nested types.
No issues found — good bones! Clean, minimal fix. New types are properly exported via the barrel export *. Test updated correctly. Woof!
There was a problem hiding this comment.
Pull request overview
Aligns the Management SDK’s TenantSettings TypeScript types with the underlying proto/API so tenant settings requests/responses use the correct field names and support newly available settings.
Changes:
- Renamed
TenantSettings.sessionSettingsEnabled→TenantSettings.enabledto match the proto field. - Added
ssoSetupSuiteSettings?: SSOSetupSuiteSettingstoTenantSettingsplus new exportedSSOSetupSuiteSettings*types. - Updated tenant management tests to use the renamed
enabledproperty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/management/types.ts | Updates TenantSettings shape to match the proto API; introduces new SSO setup suite settings types/field. |
| lib/management/tenant.test.ts | Updates mocked tenant settings to use the new enabled field name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
sessionSettingsEnabled→enabledinTenantSettingsto match theConfigureTenantSettingsRequestproto field — the old name was silently ignored by the APIssoSetupSuiteSettings?: SSOSetupSuiteSettingsfield toTenantSettingsSSOSetupSuiteSettingsandSSOSetupSuiteSettingsDisabledFeaturesFixes https://github.com/descope/etc/issues/15202
Test plan
configureSettingscorrectly sendsenabledin the request bodygetSettingsresponse maps toenabledcorrectlyssoSetupSuiteSettingscan be passed throughconfigureSettings🤖 Generated with Claude Code