Skip to content

fix(tenant): correct TenantSettings type to match proto API #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asafshen merged 1 commit into from
Apr 26, 2026
+17 −2
Merged

fix(tenant): correct TenantSettings type to match proto API #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/management/tenant.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const mockTenants = [
const mockSettings: TenantSettings = {
domains: ['domain1.com'],
selfProvisioningDomains: ['domain1.com'],
sessionSettingsEnabled: true,
enabled: true,
refreshTokenExpiration: 12,
refreshTokenExpirationUnit: 'days',
sessionTokenExpiration: 10,
Expand Down
17 changes: 16 additions & 1 deletion lib/management/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,28 @@ export type Tenant = {
defaultRoles?: string[];
};

export type SSOSetupSuiteSettingsDisabledFeatures = {
saml?: boolean;
oidc?: boolean;
scim?: boolean;
ssoDomains?: boolean;
groupMapping?: boolean;
};

export type SSOSetupSuiteSettings = {
enabled?: boolean;
styleId?: string;
disabledFeatures?: SSOSetupSuiteSettingsDisabledFeatures;
};

/** Represents settings of a tenant in a project. It has an id, a name and an array of
* self provisioning domains used to associate users with that tenant.
*/
export type TenantSettings = {
selfProvisioningDomains: string[];
domains?: string[];
authType?: 'none' | 'saml' | 'oidc';
sessionSettingsEnabled?: boolean;
enabled?: boolean;
Comment thread
asafshen marked this conversation as resolved.
Comment thread
asafshen marked this conversation as resolved.
refreshTokenExpiration?: number;
refreshTokenExpirationUnit?: ExpirationUnit;
sessionTokenExpiration?: number;
Expand All @@ -212,6 +226,7 @@ export type TenantSettings = {
InactivityTime?: number;
InactivityTimeUnit?: ExpirationUnit;
JITDisabled?: boolean;
ssoSetupSuiteSettings?: SSOSetupSuiteSettings;
};

/** Represents password settings of a tenant in a project. It has the password policy details. */
Expand Down
Loading