Merged
Conversation
+ test related to descope/etc#13177
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for custom attributes to access key Create, Read (search), and Update operations, related to issue #13177.
Changes:
- Added
customAttributesparameter tocreate,searchAll, andupdatemethods in the access key management API - Added
boundUserIdandcreatingUsersearch filter parameters tosearchAllmethod - Updated test coverage to verify the new parameters are properly passed through to the API calls
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/management/accesskey.ts | Adds customAttributes parameter to create, searchAll, and update methods; adds boundUserId and creatingUser filters to searchAll |
| lib/management/accesskey.test.ts | Updates test cases to verify new parameters are correctly passed to API endpoints |
| README.md | Updates create method example to demonstrate customAttributes usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dorsha
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to https://github.com/descope/etc/issues/13177