Skip to content

feat(user): add verifiedEmail and verifiedPhone filters to user search#704

Merged
dorsha merged 1 commit intomainfrom
feat/user-search-verified-filters
Mar 23, 2026
Merged

feat(user): add verifiedEmail and verifiedPhone filters to user search#704
dorsha merged 1 commit intomainfrom
feat/user-search-verified-filters

Conversation

@dorsha
Copy link
Member

@dorsha dorsha commented Mar 23, 2026

Summary

  • Adds verifiedEmail and verifiedPhone boolean filter fields to the SearchRequest type in user management
  • Updates README to show the new filter options in the user search example

Test plan

  • Unit tests added for both verifiedEmail: true and verifiedPhone: false filter scenarios
  • Verify the new fields are passed through correctly to the API

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings March 23, 2026 20:28
@shuni-bot-dev
Copy link

shuni-bot-dev bot commented Mar 23, 2026

🐕 Review complete — View session on Shuni Portal 🐾

@dorsha dorsha requested a review from aviadl March 23, 2026 20:28
@dorsha dorsha enabled auto-merge (squash) March 23, 2026 20:28
Copy link

@shuni-bot-dev shuni-bot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni's Review

Adds verifiedEmail and verifiedPhone optional boolean filters to the SearchRequest type for user search. The existing spread pattern in search and searchTestUsers means the new fields are automatically forwarded — no plumbing changes needed.

No issues found — good bones! Clean type addition, test covers the pass-through, README updated. Woof!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for filtering management user searches by verified email/phone status, aligning the Node SDK search request shape with the API’s filtering capabilities and documenting the new options.

Changes:

  • Extended the user SearchRequest type to include verifiedEmail and verifiedPhone boolean filters.
  • Added a unit test ensuring these new filters are passed through in the management.user.search request body.
  • Updated README user search example to demonstrate the new filters.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lib/management/user.ts Adds verifiedEmail / verifiedPhone to the search request type so callers can supply these filters.
lib/management/user.test.ts Verifies management.user.search forwards verifiedEmail / verifiedPhone to the HTTP client request body.
README.md Documents the new user search filters in the example snippet.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dorsha dorsha merged commit a23cbb1 into main Mar 23, 2026
31 checks passed
@dorsha dorsha deleted the feat/user-search-verified-filters branch March 23, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants